[Merged by Bors] - fix: dialogflow cx (PL-152) #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
zhihil
approved these changes
Sep 5, 2022
| @@ -57,6 +57,7 @@ export interface JSONEntity { | |||
| startPos: number; | |||
| endPos: number; | |||
| entity: string; | |||
| key: string; | |||
There was a problem hiding this comment.
This might need a more descriptive variable name or at least a comment with this form
/**
* This key is responsible for so-and-so
*/It's kinda hard to tell what this is and why you need it.
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Sep 5, 2022
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements PL-152** ### Brief description. What is this change? FREE Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements PL-152
Brief description. What is this change?
FREE