Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: allow template color as null (CT-674) #365

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: allow template color as null (CT-674) #365

wants to merge 1 commit into from

Conversation

viniciusdacal
Copy link
Contributor

Fixes or implements CT-674

  • When user didn't select a color, we should apply that color for the template. I added this logic on the frontend, but we need to allow null on the base-types.

@viniciusdacal viniciusdacal self-assigned this Sep 12, 2022
@viniciusdacal viniciusdacal marked this pull request as ready for review September 12, 2022 13:50
@viniciusdacal
Copy link
Contributor Author

bors r+

bors-vf bot pushed a commit that referenced this pull request Sep 12, 2022
@viniciusdacal
feat: allow template color as null (CT-674) (#365)
544232b 
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements CT-674**
 - When user didn't select a color, we should apply that color for the template. I added this logic on the frontend, but we need to allow null on the base-types.
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bors-vf
Copy link

bors-vf bot commented Sep 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors-vf bors-vf bot changed the title feat: allow template color as null (CT-674) [Merged by Bors] - feat: allow template color as null (CT-674) Sep 12, 2022
@bors-vf bors-vf bot closed this Sep 12, 2022
@bors-vf bors-vf bot deleted the vinicius/drop-template-onto-canvas/CT-674 branch September 12, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandasteinhauer amandasteinhauer amandasteinhauer approved these changes

@filipemerker filipemerker Awaiting requested review from filipemerker

Assignees

@viniciusdacal viniciusdacal

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viniciusdacal @amandasteinhauer