[Merged by Bors] - feat: update trace names (PL-000) #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecathectZero
changed the title
|
This would break any implementations relying on the old names. We should keep the old names too and add a deprecated jsdoc to each. |
|
Kudos, SonarCloud Quality Gate passed!
|
@trs I updated it with old values, but typescript in IDEs will not be able to reference the "deprecate" tags: https://stackoverflow.com/questions/49151748/es-modules-deprecate-export |
pmvrmc
approved these changes
Oct 6, 2022
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements PL-000** ### Brief description. What is this change? We forgot to export the card trace from `Trace` `Trace.SpeakTrace` -> `Trace.Speak` this is meant as work for the `adapters` repo Co-authored-by: Tyler Han <tylerhan97@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements PL-000
Brief description. What is this change?
We forgot to export the card trace from
TraceTrace.SpeakTrace->Trace.Speakthis is meant as work for the
adaptersrepo