Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable substitution in depends for subpkg #21252

Closed
svenper opened this issue Apr 22, 2020 · 1 comment · Fixed by #21264
Closed

variable substitution in depends for subpkg #21252

svenper opened this issue Apr 22, 2020 · 1 comment · Fixed by #21264

Comments

@svenper
Copy link
Contributor

svenper commented Apr 22, 2020

System

  • xuname:
    Void 5.4.33_2 x86_64-musl GenuineIntel uptodate hold rrnFFFFFFFFFF
  • package:
    python-hyper-h2-3.1.1_2

Expected behavior

variable substitution works in subpkg depends

Actual behavior

variable substitution in subpkg depends results in empty depends

Steps to reproduce the behavior

(should probably be double slash ${depends//... for global replace but that's irrelevant for this issue)

$ grep -E '\bdepends=' srcpkgs/python3-hyper-h2/template
depends="python python-hpack python-hyperframe"
        depends="${depends/python/python3}"
$ xbps-query -Rx python3-hyper-h2
$
@Chocimier
Copy link
Member

Interesting that depends, unlike short_desc is unset here, but I would change template rather than xbps-src because it's bad for searchability of python3-* usage.

Also this seems to be only template doing this.

svenper added a commit to svenper/void-packages that referenced this issue Apr 23, 2020
svenper added a commit to svenper/void-packages that referenced this issue Apr 24, 2020
Hoshpak pushed a commit that referenced this issue Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants