Tomb 2.8 error line 429, duplicate "getpasspass" output=$(pinentry_assuan_getpassgetpasspass | pinentry-curses)

[darmon77]

System

• xuname: Void 5.9.13_1 x86_64 GNU/Linux Intel

• package: tomb-2.8_1

Expected behavior

tomb open secreto.tomb -k secreto.tomb.key
tomb . Commanded to open tomb /home/darmon/secreto.tumb
tomb . Valid tomb file found: /home/darmon/secreto.tumb
tomb . Key is valid.
tomb . Mountpoint not specified, using default: /media/secreto
tomb () Opening secreto on /media/secreto
tomb . This tomb is a valid LUKS encrypted device.
tomb . Cipher is "aes" mode "xts-plain64:sha256" hash "sha256"
tomb . A password is required to use key /home/darmon/secreto.tomb.key
tomb . Password OK.
tomb () Success unlocking tomb secreto
tomb . Checking filesystem via /dev/loop1
fsck from util-linux 2.36
secreto: clean, 223/127512 files, 57720/509952 blocks
tomb (*) Success opening secreto.tumb on /media/secreto
tomb . Last visit by root(0) from /dev/pts/5 on Dennis
tomb . on date Mon Dec 14 15:43:14 2020

Actual behavior

tomb open secreto.tomb -k secreto.tomb.key
tomb . Commanded to open tomb /home/darmon/secreto.tomb
tomb . Valid tomb file found: /home/darmon/secreto.tomb
tomb . Key is valid.
tomb . Mountpoint not specified, using default: /media/secreto
tomb (*) Opening secreto on /media/secreto
tomb . This tomb is a valid LUKS encrypted device.
tomb . Cipher is "aes" mode "xts-plain64:sha256" hash "sha256"
tomb . A password is required to use key /home/darmon/secreto.tomb.key
ask_password:59: command not found: pinentry_assuan_getpassgetpasspass
tomb [W] User aborted password dialog.
tomb [E] No valid password supplied.

Steps to reproduce the behavior

error line 429
output=$(pinentry_assuan_getpassgetpasspass | pinentry-curses)

**Solution **
output=$(pinentry_assuan_getpass | pinentry-curses)

[biopsin]

Yeah needs a update to 2.8.1 as this was fixed in dyne/tomb@da590fb

[ericonr]

Could you make a PR for it? Should be pretty simple.

[biopsin]

well I could do it, however is it fine to ignore these build warnings dyne/tomb#399
As I'm not a tomb user; I don't want to push something that might brake something write dependent by any chance, knowing my luck in these matters ;p
@diogoleal @darmon77 any chance you would update and test, since one of you are using it?

[ericonr]

@biopsin you can make a PR and ask for testers there, too :)

[darmon77]

The only difference between the tomb void package and the dyne package is line
429: pkg void 2.8.0= output=$(pinentry_assuan_getpassgetpasspass | pinentry-curses) dyne/tomb#399
429: pkg dyne 2.8.1= output=$(pinentry_assuan_getpass | pinentry-curses)
771: pkg void 2.8.0= local fd=1
771: pkg dyne 2.8.1= local fd=2
783: pkg void 2.8.0= fd=2
783: pkg dyne 2.8.1= ;;

Tested in musl and glibc x86_64, all perfect.
Just update the dyne package