correctly set archs in assorted templates #12381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vboot-utils still marks aarch64 as broken despite your addition in |
|
That is ok, the archs line is correct - breakage != supported architectures |
[ci skip]
|
rebase |
Johnnynator
reviewed
Jun 18, 2019
| @@ -5,6 +5,7 @@ pkgname=android-tools | |||
| # curl -L http://git.io/vvC0Z | sh -s 5.0.2_r1 5.1.0_r1 | |||
| version=9.0.0r35 | |||
| revision=1 | |||
| archs="x86_64* i686*" | |||
There was a problem hiding this comment.
Sure about this one? E.g. Alpine lists x86 x86_64 aarch64 armv7 armhf
There was a problem hiding this comment.
Edit: alpinelinux/aports@67283cd
Leave it as you done for now, my statement for nocross also applies for native arm, so we would need to set -Wno-error=attributes can test it somewhen later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.