Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: otus-2.0 #13026

Closed
wants to merge 1 commit into from
Closed

New package: otus-2.0 #13026

wants to merge 1 commit into from

Conversation

rc-05-zz
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@rc-05-zz rc-05-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The otus (*opus is a typo) repl could only be compiled for amd64 and i686

Added "nocross" flag.

The repl for the otus interpreter could not be compiled for architectures other that i686 and amd64
@Chocimier
Copy link
Member

This patch fixes cross compilation.
I would name that package ol, like in urls and executable.

@rc-05-zz
Copy link
Contributor Author

rc-05-zz commented Jul 13, 2019

This patch fixes cross compilation.
I would name that package ol, like in urls and executable.

Do I also need to rename the directory from "otus" to "ol" or is it best that I create a completely new package (I personally think this is the best option so that I avoid screwing up the repo).

@rc-05-zz
Copy link
Contributor Author

Thinking about it it's better than I close this pull request and create a brand new package with the patch you suggested to apply @Chocimier.

@rc-05-zz rc-05-zz closed this Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants