-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipewire: update to 0.3.6 #20413
pipewire: update to 0.3.6 #20413
Conversation
3e4b14f
to
4ed3c81
Compare
The xdg-desktop-portal update is a pre releases and conditional patches are big no go. |
Oh, I didn't realized it was a pre-release. I'll try to upstream the patch (given that glibc has |
@sirn you can prefix the PR's title with |
I've bumped |
@sirn God knows when 1.8.0 will be released ! |
@mnabid I've cherry-pick |
Sorry for the noise. Back to WIP again because of Mutter. |
Now that I think about it... |
Looks like so far only mutter hasn't been updated:
Is it possible to version bump just Mutter, or that requires the rest of GNOME 3.36 as well? In the latter case I guess it makes more sense that I'll close this PR and let #21382 incorporate pipewire-0.3? |
Yeah, rest of 3.36. |
A patch at https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1062 does seems to get mutter to built against pipewire 0.3. I'm not sure if I need to revbump something else. @mnabid do you mind testing if screencast under this patched mutter-3.34 works? |
@sirn Yeah, works fine. Thanks ! Maybe edit the PR description to match the current state of this PR. |
e7495d1
to
57525f5
Compare
47acc1f
to
07c341d
Compare
I don't know anything about arm, neon, etc but unless the detection fails due to something void specific maybe it's worth reopening https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/235 |
Now failing due to ICU... probably because of recent ICU update missing some revbump? |
Builders are still busy rebuilding stuff for ICU 67.1 https://build.voidlinux.org/waterfall |
No, I take that back. I'm still getting the same error in Travis. Sorry for bothering. |
All greens! |
Seems like everything is awesome ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trusting in my review capabilities.
looks good for me, but i won't test this.
Is it really preferable to patch e.g. |
Bumped to 0.3.6 and address @Piraty's review (the patch is not a complete revert, just removing NEON from armv6l/armv7l check). Pipewire is now marked as required in
I believe they're following odd-unstable/even-stable release pattern. |
There is a conflict now on mutter. is anyone working on this?
many moons ago i was looking into upgrading mutter but this was the conflict. i could look into this again if it is not being pursued. also |
Weird, there's already a patch to fix this at 3b2f6c2 |
@bobertlo are you sure? i hit sth similar as well due to my version of mutter being manually built from testing a gnome update PR
|
I installed
|
Oh wow I forgot I patched mutter for a bug. I had a backport PR then decided to wait for 3.36. sorry lol |
This PR updates
pipewire
to 0.3.6 and also updating/patching all packages that depends on it.xdg-desktop-portal
includes a patch backported from 1.7.0 to allow 1.6.0 to build against pipewire-0.3 (1.7.x is prerelease)xdg-desktop-portal-kde
requires pkg-config to detect pipewire-0.3 because of include dir version suffix.mutter
includes a patch backported from 3.35 to allow 3.34 to build against pipewire-0.3 (upgrading to >=3.35 also requires upgrading GNOME).