Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

herbstluftwm: update to 0.8.0 #20961

Merged
merged 1 commit into from
Apr 15, 2020
Merged

herbstluftwm: update to 0.8.0 #20961

merged 1 commit into from
Apr 15, 2020

Conversation

Nairou
Copy link
Contributor

@Nairou Nairou commented Apr 13, 2020

No description provided.

@Nairou Nairou force-pushed the patch-1 branch 2 times, most recently from 65c1008 to 5032be2 Compare April 13, 2020 22:16
@Nairou
Copy link
Contributor Author

Nairou commented Apr 13, 2020

Works on x64. Not sure why CI complains about X11 for other platforms. I tried adding a libX11-devel dependency, but it didn't help.

@natrys
Copy link
Contributor

natrys commented Apr 14, 2020

Any reason you don't just use build_style=cmake? It will take care of cross-building. That way you can also get rid of do_build and do_install blocks. Move license and completions stuffs to post_install. You can test locally for other archs (like e.g. ./xbps-src -a aarch64 pkg herbstluftwm).

@Nairou
Copy link
Contributor Author

Nairou commented Apr 14, 2020

Any reason you don't just use build_style=cmake? It will take care of cross-building. That way you can also get rid of do_build and do_install blocks. Move license and completions stuffs to post_install. You can test locally for other archs (like e.g. ./xbps-src -a aarch64 pkg herbstluftwm).

Testing other archs locally sounds great. Where can I see how to use build_style? These are new changes, the previous version didn't use cmake.

I'm just an end-user trying to get an orphaned package updated for the first time. 😄

@mustaqimM
Copy link
Contributor

@travankor
Copy link
Contributor

travankor commented Apr 15, 2020

Basically, get rid of do_build() and do_install() sections and add build_style=cmake below revision. Everything should just work, but you might need to make a few adjustments. Once you get it working run xlint to fix errors up.

@Nairou
Copy link
Contributor Author

Nairou commented Apr 15, 2020

@natrys @mustaqimM @travankor Thank you for your help! I think I'm getting the hang of this. 😄

@Hoshpak Hoshpak merged commit 44f452e into void-linux:master Apr 15, 2020
@Nairou Nairou deleted the patch-1 branch April 15, 2020 15:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants