Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Gauche-0.9.9 #21205

Merged
merged 1 commit into from May 18, 2020
Merged

New package: Gauche-0.9.9 #21205

merged 1 commit into from May 18, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2020

Description from upstream:

Gauche is an R7RS Scheme implementation developed to be a handy script interpreter, which allows programmers and system administrators to write small to large scripts for their daily chores. Quick startup, built-in system interface, native multilingual support are some of my goals.

@Chocimier
Copy link
Member

Cross compilation passes with Gauche added to hostmakedepends conditionally.

Conflicts with gosh package that installs /usr/bin/gosh too.

@ghost
Copy link
Author

ghost commented Apr 22, 2020

Cross compilation passes with Gauche added to hostmakedepends conditionally.

Conflicts with gosh package that installs /usr/bin/gosh too.

Now the application will not conflict anymore with the gosh package and Gauche was added to hostmakedepends as you suggested.

@ghost
Copy link
Author

ghost commented Apr 22, 2020

Let's see if Travis CI can build at least for the archs with glibc runtime.

@Chocimier
Copy link
Member

Let's see if Travis CI can build at least for the archs with glibc runtime.

I encourage you to look at build logs on travis to see what real problem is.

For cross compilation, problem is that gosh is executed during build. When it is native built, a while-ago created binary can be used. When cross-built, it cannot, but one can install native gosh by adding to hostmakedepends.

But if you simply add Gauche to hostmakedepends, there is need for Gauche to build Gauche. Solution is to only depend on Gauche in case of cross build, take a look for template of php.

@ghost
Copy link
Author

ghost commented Apr 25, 2020

Let's see if Travis CI can build at least for the archs with glibc runtime.

I encourage you to look at build logs on travis to see what real problem is.

For cross compilation, problem is that gosh is executed during build. When it is native built, a while-ago created binary can be used. When cross-built, it cannot, but one can install native gosh by adding to hostmakedepends.

But if you simply add Gauche to hostmakedepends, there is need for Gauche to build Gauche. Solution is to only depend on Gauche in case of cross build, take a look for template of php.

Ok thanks! I'm going to follow your suggestions. Looking at the build logs it seems that it doesn't find the man page so it's a minor stuff that can be easily fixed

@ghost
Copy link
Author

ghost commented Apr 25, 2020

Could you (or others) please review #21258, #21183, #20739 and (eventually) merge? @Chocimier

srcpkgs/Gauche/template Outdated Show resolved Hide resolved
srcpkgs/Gauche/template Outdated Show resolved Hide resolved
srcpkgs/Gauche/template Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Apr 28, 2020

I think that I've resolved the renaming issue... Compiling locally to see if the cross package is generated.

@ghost
Copy link
Author

ghost commented Apr 29, 2020

I think that for some reason at install point the gauche interpreter is not found... Maybe the internal makefile contains an undocumented flag/variable or even worse it's hardcoded and a patch is needed..

I'm surprisingly having an hard time packaging Gauche: should I mark this pull request as WIP at this point? @Chocimier

@ghost ghost changed the title New package: Gauche-0.9.9 [WIP] New package: Gauche-0.9.9 Apr 30, 2020
@ghost
Copy link
Author

ghost commented Apr 30, 2020

Marked as [WIP] as I am trying to figure out how to successfully resolve the binary conflict with Gosh and Cross Compiling

@Chocimier
Copy link
Member

You can just set conflicts variable if installing Gauche aside of gosh is ok for you, with short comment explaining reason.

@Chocimier
Copy link
Member

*forbidding installing

@ghost
Copy link
Author

ghost commented Apr 30, 2020

I could have done that and call it a day but maybe there are people that use both Gosh and Gauche for some reason or another so there's that... And maybe I think that I've finally resolved the naming conflict after days and days...

@ghost ghost changed the title [WIP] New package: Gauche-0.9.9 New package: Gauche-0.9.9 Apr 30, 2020
@Chocimier
Copy link
Member

Much better now.

Conditional post_install is, fortunately, overwritten by other one, manpage name should be same whether cross-compiled or not. Please remove.

Is libatomic_ops-devel needed, or not?

--host is already set bu build style.

Install messages are mentioned for more important things, renamed binary can be known from xbps-query -f.

@ghost ghost requested a review from Chocimier May 3, 2020 22:02
@ghost
Copy link
Author

ghost commented May 3, 2020

The libatomic library is not mandatory: for simplicity's sake I've removed it from the template.
Should instead be added as a build option?

@Chocimier
Copy link
Member

As you wish. I think it's ready to merge.

@ghost
Copy link
Author

ghost commented May 7, 2020

Hmmm then I'll add it as a build option and push the commit asap
The more alternatives the better 🙂

@ghost
Copy link
Author

ghost commented May 7, 2020

Build option added: I also think that this package can be finally merged into master repo of void-packages

@Chocimier
Copy link
Member

I'm still unsure if libatomic should be option or enabled based on $XBPS_TARGET_NO_ATOMIC8, or both.

@ghost
Copy link
Author

ghost commented May 11, 2020

I think that it would be better to leave it as a build option since it is not mandatory

@Chocimier
Copy link
Member

Documentation says, that bundled libatomic is used, if needed and not found in system. Remove build option and add libatomic to makedepends unconditionally.

@Chocimier Chocimier merged commit 7a9ab5b into void-linux:master May 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant