Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs: remove unused init scripts and add zed service #23689

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

ahesford
Copy link
Member

@ahesford ahesford commented Jul 21, 2020

Small changes to:

  1. Remove /etc/init.d scripts that aren't used in Void,
  2. Remove /etc/default/zfs config script that isn't used, and
  3. Add a service to run zed.

[edit: also remove /etc/zfs/zfs-functions]

@Vaelatern @zdykstra @ericonr

@zdykstra
Copy link
Contributor

It's possible that /etc/zfs/zfs-functions can also be removed. The only references I can find to that file are in the errant /etc/init.d/zfs-* scripts that are being purged as part of this PR. I can test removing that as well tonight.

@ahesford
Copy link
Member Author

You're right, and it says it's intended for the init.d scripts right at the top. Removed.

Comment on lines +1 to +3
#!/bin/sh
[ -r conf ] && . conf
exec zed -F $OPTS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a recommended service?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful if you care about receiving notifications for ZFS events, but I'm not sure I'd call it "recommended".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Just wondering about the docs side of it c:

Thanks

@ahesford ahesford merged commit ba2dd95 into void-linux:master Jul 23, 2020
@ahesford ahesford deleted the zfs branch July 23, 2020 17:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants