build-style/cmake: only look into masterdir libraries #26039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of it's now, cmake will look into host's libraries, thus bootstrapping will fail at ccache if host system doesn't have libzstd-devel installed.
sgn
force-pushed
the
bootstrap-cmake-build-style
branch
from
7410f6f
to
f7cc827
Compare
|
Add John since John frequently touches cmake stuff |
|
I'm not too acquainted with cmake thus I can only tell that to me it makes sense to not have |
|
Only because I touch cmake stuff frequently, doesn't mean that I'm experienced in that mess. It looks fine on first glance, and since it is dependent on CHROOT_READY not being set, it won't break anything actively even if it is wrong (which it doesn't look like). |
|
i don't see this breaking anything, even potentially, considering |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of it's now, cmake will look into host's libraries, thus
bootstrapping will fail at ccache if host system doesn't have
libzstd-devel installed.