Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build kernels reproducibly #26775

Closed
wants to merge 6 commits into from
Closed

Conversation

Piraty
Copy link
Member

@Piraty Piraty commented Nov 28, 2020

@Piraty
Copy link
Member Author

Piraty commented Nov 29, 2020

even better to export those on toplevel i think?

@ericonr
Copy link
Member

ericonr commented Nov 29, 2020

Can these be exported as environment variables or do you need to put them in front of make?

@Piraty
Copy link
Member Author

Piraty commented Nov 30, 2020

export should work

Can these be exported as environment variables or do you need to put them in front of make?

can be exported. appears more pretty to me, will push a modified version

@Piraty
Copy link
Member Author

Piraty commented Dec 2, 2020

updated, now exporting on global scope

@pullmoll
Copy link
Member

pullmoll commented Dec 2, 2020

Perhaps you can combine this #26882 request with the update?
Other than that LGTM.

@Piraty Piraty closed this Dec 4, 2020
@Piraty Piraty deleted the kernel-repro branch December 4, 2020 17:33
@Piraty
Copy link
Member Author

Piraty commented Dec 4, 2020

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants