Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppStream: update to 0.13.1 #26862

Merged
merged 1 commit into from
Dec 2, 2020
Merged

AppStream: update to 0.13.1 #26862

merged 1 commit into from
Dec 2, 2020

Conversation

gspe
Copy link
Contributor

@gspe gspe commented Dec 1, 2020

No description provided.

version=0.12.11
revision=2
version=0.13.1
revision=1
wrksrc="appstream-${version}"
build_style=meson
build_helper="gir qemu"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the qemu build helper required? I see nothing running in under emulation in this template.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the meson build style can use qemu automatically. But I think specifying gir should be enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the qemu build helper required? I see nothing running in under emulation in this template.

Without it the cross builds were failing with:

Cannot use target appstreamcli as a generator because it is built for the
host machine and no exe wrapper is defined or needs_exe_wrapper is
true. You might want to set `native: true` instead to build it for
the build machine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, thanks for checking.

@ahesford ahesford merged commit e1a5087 into void-linux:master Dec 2, 2020
@gspe gspe deleted the appstream branch January 7, 2021 17:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants