-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnucash: update to 4.4 #27504
gnucash: update to 4.4 #27504
Conversation
The checks fail because they try to execute |
What does the third parameter in "Build packages (x86_64, x86_64, 1)" mean? For the builds where it is set to 0 the build succeeds. |
The 1 means that tests are being run. |
Thanks. So this explains why only those with 1 fail. Can this pr still be processed? Maybe some tests are failing because Gnucash has got an automatic build and test bot on Travis CI to run the full test suite after every commit and for every Github pull request, so the released code should be fine anyway. See https://wiki.gnucash.org/wiki/Testing. I will try with |
With The following tests FAILED: I will try to fix those as well, therefore I have set the PR to WIP. |
55 - test-gnc-timezone and The remaining failures appear to be down to not having the fr_FR and de_DE locales installed. The locales are needed only for testing, so imho this is ok now and ready to go. |
You should either disable those two tests or else add |
6de80cf
to
dd100c0
Compare
@Hoshpak Could somebody pls review this PR and merge, if possible? Thanks! :-) |
Please squash commits. |
Fix use-after-free in test_xaccTransEqual Disable two tests which require having the fr_FR and de_DE locales installed. Add tzdata as dependency Make_check_target=check
Done. |
@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...