Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnucash: update to 4.4 #27504

Merged
merged 1 commit into from
Feb 7, 2021
Merged

gnucash: update to 4.4 #27504

merged 1 commit into from
Feb 7, 2021

Conversation

manfredu
Copy link
Contributor

@manfredu manfredu commented Dec 28, 2020

@Hoshpak: Could you pls have a look at this PR? I'm not sure what to do about the unsuccessful checks...

@unspecd
Copy link
Contributor

unspecd commented Dec 28, 2020

#27320 (comment)

@manfredu manfredu changed the title gnucash: update to 4.3 gnucash: update to 4.4 Dec 29, 2020
@Hoshpak
Copy link
Member

Hoshpak commented Dec 31, 2020

The checks fail because they try to execute make check and it seems most of the test binaries are not available. To make them pass, it would be necessary to find out what is missing for the build process to build the tests and make sure they are compiled in the build process.

@manfredu
Copy link
Contributor Author

manfredu commented Jan 2, 2021

The checks fail because they try to execute make check and it seems most of the test binaries are not available. To make them pass, it would be necessary to find out what is missing for the build process to build the tests and make sure they are compiled in the build process.

What does the third parameter in "Build packages (x86_64, x86_64, 1)" mean? For the builds where it is set to 0 the build succeeds.

@fosslinux
Copy link
Contributor

The 1 means that tests are being run.

@manfredu
Copy link
Contributor Author

manfredu commented Jan 3, 2021

The 1 means that tests are being run.

Thanks. So this explains why only those with 1 fail.

Can this pr still be processed?

Maybe some tests are failing because make test is used? Only make check builds and runs the full test suite. Some tests depend on additional libraries and the cmake built-in target test does not build them. Once the check target has been built check and test are synonyms.

Gnucash has got an automatic build and test bot on Travis CI to run the full test suite after every commit and for every Github pull request, so the released code should be fine anyway.

See https://wiki.gnucash.org/wiki/Testing.

I will try with make_check_target=check.

@manfredu manfredu changed the title gnucash: update to 4.4 [WIP] gnucash: update to 4.4 Jan 3, 2021
@manfredu
Copy link
Contributor Author

manfredu commented Jan 3, 2021

With make_check_target=check only 4 tests failed out of 111:

The following tests FAILED:
31 - test-qof (Subprocess aborted)
54 - test-gnc-numeric (Failed)
55 - test-gnc-timezone (Failed)
56 - test-gnc-datetime (Failed)

I will try to fix those as well, therefore I have set the PR to WIP.

@manfredu
Copy link
Contributor Author

manfredu commented Jan 3, 2021

55 - test-gnc-timezone and
56 - test-gnc-datetime
no longer fail after adding tzdata as dependency.

The remaining failures appear to be down to not having the fr_FR and de_DE locales installed. The locales are needed only for testing, so imho this is ok now and ready to go.

@manfredu manfredu changed the title [WIP] gnucash: update to 4.4 gnucash: update to 4.4 Jan 3, 2021
@fosslinux
Copy link
Contributor

You should either disable those two tests or else add || : # some comment indicating that the failures are due to lack of locales to the end of the make check block to make the tests pass.

@manfredu manfredu force-pushed the gnucash branch 3 times, most recently from 6de80cf to dd100c0 Compare February 6, 2021 19:04
@manfredu
Copy link
Contributor Author

manfredu commented Feb 6, 2021

@Hoshpak Could somebody pls review this PR and merge, if possible? Thanks! :-)

@pullmoll
Copy link
Member

pullmoll commented Feb 6, 2021

Please squash commits.

Fix use-after-free in test_xaccTransEqual
Disable two tests which require having the fr_FR and de_DE locales installed.
Add tzdata as dependency
Make_check_target=check
@manfredu
Copy link
Contributor Author

manfredu commented Feb 6, 2021

Please squash commits.

Done.

@Hoshpak Hoshpak merged commit 459c461 into void-linux:master Feb 7, 2021
@manfredu manfredu deleted the gnucash branch February 8, 2021 10:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants