Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ASPM for PCIe, SATA Link power management #27846

Merged
merged 9 commits into from
Jan 19, 2021

Conversation

abenson
Copy link
Contributor

@abenson abenson commented Jan 11, 2021

Seems to fix #27806. It's already set for ppc32, but not for the other archs. Not sure if it should be applied across the board, feedback is appreciated.

@abenson
Copy link
Contributor Author

abenson commented Jan 11, 2021

Also could maybe drop the revision bump and just let it happen on the next kernel update.

@ericonr
Copy link
Member

ericonr commented Jan 12, 2021

Maybe leave the revbump only in 5.9, since it's not going to receive updates. Alternatively, don't touch it at all, since it's going to be removed soon and we shouldn't be encouraging people to use it.

@abenson
Copy link
Contributor Author

abenson commented Jan 12, 2021

Dropped the change for 5.9.

@abenson abenson changed the title unify CONFIG_SATA_MOBILE_LPM_POLICY setting across kernels enable ASPM for PCIe, SATA Link power management Jan 15, 2021
@dkwo
Copy link
Contributor

dkwo commented Jan 16, 2021

Looks good to me.

@joey-commits
Copy link
Contributor

I built a kernel with all the changes in this branch and the ASPM changes allow my laptop to reach PC8 with display on and PC10 with display off. I must run powertop --auto-tune, however, this is the same is in arch. I think we have solved the issues surrounding this for now.

@dkwo
Copy link
Contributor

dkwo commented Jan 18, 2021

@joey-commits Same for me, provided I use glibc and not musl.
@ericonr Do you think it could me merged?
Thanks.

@ericonr
Copy link
Member

ericonr commented Jan 18, 2021

That's up to @abenson, mostly. Would be good to do before new kernels are pushed.

@abenson abenson merged commit cee91f6 into void-linux:master Jan 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skylake CPU cannot enter package states lower than PC3
4 participants