Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: python3-curio-1.4 #28419

Closed
wants to merge 1 commit into from
Closed

Conversation

ar-jan
Copy link
Contributor

@ar-jan ar-jan commented Feb 2, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

Reason

#28272 keeps getting stuck on CI so I want to see if adding dependencies one by one would pass tests.

@ar-jan
Copy link
Contributor Author

ar-jan commented Feb 8, 2021

On CI the following builds succeed:

aarch64, x86_64
armv7l, x86_64
armv6l-musl, x86_64-musl
aarch64-musl, x86_64-musl

Locally on an x86_64 system the tests also pass. But for some reason x86_64, x86_64, i686, i686, and x86_64-musl, x86_64-musl run out of time on CI without any reported errors. On #voidlinux channel a CI connectivity problem was suggested as a possible reason. Since it builds successfully on most arches I've disabled tests and added a note.

@Chocimier
Copy link
Member

Don't send here PRs that you do not want to be merged. To test things, send them to your own fork.

Please do not disable tests that pass locally. Please comment in template instead.

Here, failure in CI is because container have some privileges that https://github.com/dabeaz/curio/blob/1.4/tests/test_network.py#L317 don't expect - please disable that one test with pytest -k.

@Chocimier Chocimier closed this Feb 8, 2021
@ar-jan
Copy link
Contributor Author

ar-jan commented Feb 8, 2021

OK, will do.

I thought the new dependencies might have to be added in separate pull requests because there was no way to proceed with the the original #28272 and find out which specific package was at issue.

To test things, send them to your own fork.

I wanted to see CI test results for individual packages because it seemed there were no other options to find out what was going on. Are CI tests possible on individual forks, or what do you mean by testing?

Here, failure in CI is because container have some privileges that https://github.com/dabeaz/curio/blob/1.4/tests/test_network.py#L317 don't expect - please disable that one test with pytest -k.

Aha! Any way I could have discovered that? There were no errors or warnings.

@Chocimier
Copy link
Member

Any way I could have discovered that?

When you are logged in, there is a box above comment box at this page. Click "Details" for given architecture, then browse logs. There is a convenient text form of logs under three-dots-menu - "View raw logs".

@ar-jan ar-jan deleted the python3-curio branch February 17, 2021 14:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants