Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ell 0.38 bluez 5.56 #28488

Closed
wants to merge 3 commits into from
Closed

ell 0.38 bluez 5.56 #28488

wants to merge 3 commits into from

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Feb 4, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr ericonr changed the title ell: update to 0.37. [NOMERGE] nell: update to 0.37. Feb 4, 2021
@ericonr
Copy link
Member Author

ericonr commented Feb 4, 2021

Welp, they broke ABI

@ericonr ericonr marked this pull request as draft February 4, 2021 18:57
@ericonr
Copy link
Member Author

ericonr commented Feb 4, 2021

Should wait on IWD 1.12. I'm considering moving it to use built-in ELL to avoid ABI/API mismatches (IWD 1.11 won't even build with this one).

@sgn what do you think about doing the same for bluez?

@ericonr ericonr changed the title [NOMERGE] nell: update to 0.37. [NOMERGE] ell: update to 0.37. Feb 4, 2021
@sgn
Copy link
Member

sgn commented Feb 5, 2021

I'm expecting new release of bluez soon. In my experience, ell don't break that often.

@ericonr
Copy link
Member Author

ericonr commented Feb 5, 2021

From what I understand, most of the time the releases come out near each other, ell, bluez and IWD. But since they are so tied to a specific ll version, I'm not sure we gain much by using the dynamic library... It's tiny and using the bundled one helps avoid weird compatibility issues.

Since I'd consider wireless generally more essential than bt, we could link only IWD with the bundled version.

@sgn
Copy link
Member

sgn commented Feb 5, 2021

Seems like Debian (which wants to dynamic link the most) also uses bundled version for iwd. I think it should be fine.
They uses external ell for bluez, though.

@ericonr ericonr changed the title [NOMERGE] ell: update to 0.37. iwd 1.12 ell 0.38 bluez 5.56 Feb 26, 2021
@ericonr ericonr marked this pull request as ready for review February 26, 2021 20:23
@ericonr ericonr requested review from sgn and ahesford February 26, 2021 20:23
@sgn
Copy link
Member

sgn commented Feb 27, 2021

BlueZ: hold for a bit https://marc.info/?l=linux-bluetooth&m=161437459815658&w=2

Copy link
Member

@ahesford ahesford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iwd seems to work fine as a WPA supplicant and link manager. IPv6 still fails to work as expected. In my network, which offers Router Advertisements for IPv6 configuration, iwd crashes when it is configured to enable IPv6. Earlier versions supported only DHCPv6 for IPv6, but I don't rememember if that caused iwd to crash or just fail to give me a v6 address before. I can't comment on DHCPv6 functionality.

For now, iwd still fails to deliver key IPv6 support, which leaves me turning off network configuration and using dhcpcd. This is nothing new and, unless previously working DHCPv6 support is broken, probably shouldn't block this update.

I continue to wait for the day when iwd handles IPv6 properly and I can drop my dhcpcd dependnecy.

@sgn
Copy link
Member

sgn commented Mar 1, 2021

I would say switch BlueZ to vendor ell for now (if bluez failed to build from source with new ell) and push ell and iwd out first.


BlueZ 5.55 built fine with new ell?

@ericonr
Copy link
Member Author

ericonr commented Mar 1, 2021

BlueZ 5.55 built fine with new ell?

I didn't check. But now that IWD is using bundled ell, I can hold the ell update without issue.

@ericonr ericonr changed the title iwd 1.12 ell 0.38 bluez 5.56 ell 0.38 bluez 5.56 Mar 11, 2021
@ericonr
Copy link
Member Author

ericonr commented Mar 11, 2021

This PR is now exclusively about ell and bluez.

@paper42
Copy link
Member

paper42 commented Apr 7, 2021

bluez 5.57 and 5.58 are out. They fix an issue in 5.56 where bluetooth headphones could connect with HSP instead of SBC/AptX etc. which meant really bad sound quality.

@paper42
Copy link
Member

paper42 commented Apr 7, 2021

  • 5.58 requires ell 0.39
  • using -n flag in the service means that bluetoothd logs to stdout, could you add logging to the service? What's the policy about logging in services in Void? When should they be included in the package?
  • could you add --enable-experimental flag to bluez as a build option? (disabled by default) This option should enable monitoring battery level with a dbus interface.

@ericonr
Copy link
Member Author

ericonr commented Apr 7, 2021

@paper42 I have pushed an updated version of the PR, could you please test it out?

Add warnings about ABI stability.
Requested by paper42:
- add logging to services
- add experimental build option
@paper42
Copy link
Member

paper42 commented Apr 7, 2021

Thanks, I will try using this for a few days and report back soon.

@paper42
Copy link
Member

paper42 commented Apr 10, 2021

I was able to test this only for a few hours before my hardware broke, but it worked fine.

@ericonr ericonr closed this Apr 11, 2021
@ericonr ericonr deleted the ell branch April 11, 2021 04:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants