-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New package: linux-steam-integration-0.7.3 #28538
Conversation
-Dwith-frontend=true" | ||
hostmakedepends="pkg-config" | ||
makedepends="gtk+3-devel" | ||
depends="gtk+3 glib glibc steam" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first three should be detected automatically once the package is built. I'm not sure this should depend on steam either... Couldn't it still be useful if you use flatpak or install it manually some other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is built to assume that normal steam is at /usr/bin/steam
, so if flatpak steam follows that, yeah, I guess it'd work
-Dwith-steam-binary=/usr/bin/steam \ | ||
-Dwith-new-libcxx-abi=true \ | ||
-Dwith-libressl-mode=native \ | ||
-Dwith-frontend=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent multiline variables with a single space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also no need for the back slashes.
pkgname=linux-steam-integration | ||
version=0.7.3 | ||
revision=1 | ||
archs="x86_64 i686" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works with flatpak steam, we should remove the limitation and allow x86_64* i686*
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this does nothing for flatpak. (except ofc if you install it inside of flatpak).
I'm not sure at all if this package should be added to the repo. For one it is not actively developed anymore, but it is guaranteed to require maintenance due to the way it is working. Furthermore it has an hard coded list of sonames and versions it can replace, so it also will get less usefull over time even if it doesn't break. Furthermore this current version should at least run into this problem: solus-project/linux-steam-integration#82 Furthermore, how many games do even really benefit from this nowadays? |
Agreed on all that. Even getting it to work at all, ideally, requires something like a
Oh right, that... Well that specific issue luckily has a patch that could be introduced here, but yeah, LSI indeed seems not quite maintained and/or useful enough now. |
General
Have the results of the proposed changes been tested?
Closes #19282, caveats:
liblsi-intercept.so
andliblsi-redirect.so
work at all for the following reason:whatever that might mean. I'm not sure if lsi-steam crash is related to lsi-steam or steam itself, any help would be appreciated.