Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New package: linux-steam-integration-0.7.3 #28538

Closed
wants to merge 1 commit into from

Conversation

xolophreny
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Closes #19282, caveats:

  • Needs both 64-bit and 32-bit packages installed to work properly
  • Couldn't test if liblsi-intercept.so and liblsi-redirect.so work at all for the following reason:
  • Manually installing replacements for steam runtime components is a challenge, at some point I got stuck with lsi-steam crashing at launch without meaningful errors, and regular steam with STEAM_RUNTIME=0 not launching with
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols
src/clientdll/appdatacache.cpp (2640) : Assertion Failed: !bSharedKVSymbols

whatever that might mean. I'm not sure if lsi-steam crash is related to lsi-steam or steam itself, any help would be appreciated.

-Dwith-frontend=true"
hostmakedepends="pkg-config"
makedepends="gtk+3-devel"
depends="gtk+3 glib glibc steam"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first three should be detected automatically once the package is built. I'm not sure this should depend on steam either... Couldn't it still be useful if you use flatpak or install it manually some other way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is built to assume that normal steam is at /usr/bin/steam, so if flatpak steam follows that, yeah, I guess it'd work

-Dwith-steam-binary=/usr/bin/steam \
-Dwith-new-libcxx-abi=true \
-Dwith-libressl-mode=native \
-Dwith-frontend=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent multiline variables with a single space.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also no need for the back slashes.

pkgname=linux-steam-integration
version=0.7.3
revision=1
archs="x86_64 i686"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works with flatpak steam, we should remove the limitation and allow x86_64* i686*.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this does nothing for flatpak. (except ofc if you install it inside of flatpak).

@Johnnynator
Copy link
Member

I'm not sure at all if this package should be added to the repo.

For one it is not actively developed anymore, but it is guaranteed to require maintenance due to the way it is working. Furthermore it has an hard coded list of sonames and versions it can replace, so it also will get less usefull over time even if it doesn't break.

Furthermore this current version should at least run into this problem: solus-project/linux-steam-integration#82

Furthermore, how many games do even really benefit from this nowadays?

@xolophreny
Copy link
Contributor Author

I'm not sure at all if this package should be added to the repo.

For one it is not actively developed anymore, but it is guaranteed to require maintenance due to the way it is working. Furthermore it has an hard coded list of sonames and versions it can replace, so it also will get less usefull over time even if it doesn't break.

Furthermore, how many games do even really benefit from this nowadays?

Agreed on all that. Even getting it to work at all, ideally, requires something like a steam-runtime meta-package that pulls runtime replacements in. Tried to cobble that together but that'd really need a clean system, which I don't have unfortunately.

Furthermore this current version should at least run into this problem: solus-project/linux-steam-integration#82

Oh right, that... Well that specific issue luckily has a patch that could be introduced here, but yeah, LSI indeed seems not quite maintained and/or useful enough now.

@xolophreny xolophreny closed this Feb 6, 2021
@xolophreny xolophreny deleted the lsi branch March 13, 2021 15:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: linux-steam-integration
3 participants