-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: nginx-mod-headers-more-0.33 #30257
New package: nginx-mod-headers-more-0.33 #30257
Conversation
119da95
to
8f0e6cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this package should depend on nginx
732525d
to
00f0f02
Compare
I also think this does not clean up the build dir correctly because of the multiple archives being extracted under different directory names. |
00f0f02
to
c797065
Compare
Coming back to this... need to fix the cross build and add a note to nginx template about keeping nginx version in sync. |
e3ffb7e
to
539b0c5
Compare
OK, fixed the cross building and added note to nginx template. This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If files/ is necessary, could we instead link files/ from ../nginx/?
No, the files aren't the same, they needed to be modified. The only file that is the same is |
43304f1
to
ee4465e
Compare
I linked files/ngx_auto_config.h.armv6l.patch to the original file in nginx/files. |
ee4465e
to
961ff29
Compare
I fixed up the depends variables by only pulling in the hostmakedepends for CROSS_BUILD, and removed a make dependency that was there in error. |
Since creating this PR, I have switched to |
General
Have the results of the proposed changes been tested?
This NGINX module is useful for quickly adding headers across all server blocks for an NGINX installation, which is useful for e.g. a one-line opting-out of Google's FLoC.