Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: nginx-mod-headers-more-0.33 #30257

Closed

Conversation

TinfoilSubmarine
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

This NGINX module is useful for quickly adding headers across all server blocks for an NGINX installation, which is useful for e.g. a one-line opting-out of Google's FLoC.

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package should depend on nginx

srcpkgs/ngx_headers_more/template Outdated Show resolved Hide resolved
srcpkgs/ngx_headers_more/template Outdated Show resolved Hide resolved
srcpkgs/ngx_headers_more/template Outdated Show resolved Hide resolved
srcpkgs/ngx_headers_more/template Outdated Show resolved Hide resolved
srcpkgs/ngx_headers_more/template Outdated Show resolved Hide resolved
srcpkgs/ngx_headers_more/template Outdated Show resolved Hide resolved
@TinfoilSubmarine TinfoilSubmarine force-pushed the ngx_headers_more branch 2 times, most recently from 732525d to 00f0f02 Compare August 14, 2021 19:27
@Duncaen
Copy link
Member

Duncaen commented Aug 14, 2021

I also think this does not clean up the build dir correctly because of the multiple archives being extracted under different directory names.
Should probably use create_wrksrc=yes to get it cleaned up automatically.

@TinfoilSubmarine TinfoilSubmarine changed the title New package: ngx_headers_more-0.33 New package: nginx-mod-headers-more-0.33 Aug 16, 2021
@TinfoilSubmarine
Copy link
Contributor Author

Coming back to this... need to fix the cross build and add a note to nginx template about keeping nginx version in sync.

@TinfoilSubmarine TinfoilSubmarine force-pushed the ngx_headers_more branch 2 times, most recently from e3ffb7e to 539b0c5 Compare September 10, 2021 15:47
@TinfoilSubmarine
Copy link
Contributor Author

OK, fixed the cross building and added note to nginx template. This is ready for review.

Copy link
Member

@paper42 paper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If files/ is necessary, could we instead link files/ from ../nginx/?

@TinfoilSubmarine
Copy link
Contributor Author

No, the files aren't the same, they needed to be modified. The only file that is the same is files/ngx_auto_config.h.armv6l.patch, which in that case we could link.

@TinfoilSubmarine TinfoilSubmarine force-pushed the ngx_headers_more branch 2 times, most recently from 43304f1 to ee4465e Compare September 17, 2021 14:47
@TinfoilSubmarine
Copy link
Contributor Author

I linked files/ngx_auto_config.h.armv6l.patch to the original file in nginx/files.

@TinfoilSubmarine
Copy link
Contributor Author

I fixed up the depends variables by only pulling in the hostmakedepends for CROSS_BUILD, and removed a make dependency that was there in error.

@TinfoilSubmarine
Copy link
Contributor Author

Since creating this PR, I have switched to caddy and no longer use nginx on a regular basis and thus would not be a good maintainer for this.

@TinfoilSubmarine TinfoilSubmarine deleted the ngx_headers_more branch November 16, 2021 13:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants