Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: update to 4.0.0 #30968

Closed
wants to merge 1 commit into from
Closed

ansible: update to 4.0.0 #30968

wants to merge 1 commit into from

Conversation

dstolfa
Copy link
Contributor

@dstolfa dstolfa commented May 18, 2021

With the major version update of ansible to 4.0.0, ansible-base has been renamed to ansible-core. This pull request addresses the changes necessary to update ansible to 4.0.0.

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@dstolfa dstolfa changed the title ansible: update to 3.4.0 ansible: update to 4.0.0 May 18, 2021
@ahesford
Copy link
Member

You should move the transitional package into the new ansible-core as a subpackage.

@ahesford
Copy link
Member

Also, ping @jcgruenhage

@dstolfa
Copy link
Contributor Author

dstolfa commented May 20, 2021

@ahesford After local testing, I believe that it behaves correctly as a subpackage now and that upgrades followed by removal of ansible-base shouldn't break ansible installations.

@jcgruenhage
Copy link
Contributor

I've built this locally and tested the changes, it seems that it all works as expected.

With the update of ansible to 4.0.0, ansible-base has been deprecated
and ansible-core is the new name of its dependency [1]. This commit
makes the following changes outside of ansible:

ansible-base is now a transitional package that depends on ansible-core.

ansible-core is what ansible-base used to be (for the most part) with
names changed where necessary.

In order to minimize the chance of users getting into a broken state,
this was all done as a single commit rather than separate ones.

[1]: https://www.ansible.com/blog/ansible-3.0.0-qa
ahesford pushed a commit that referenced this pull request May 21, 2021
@ericonr
Copy link
Member

ericonr commented May 21, 2021

There was a typo in the commit, so closing PR manually.

@ericonr ericonr closed this May 21, 2021
@dstolfa dstolfa deleted the ansible-dev branch May 21, 2021 14:00
@dstolfa dstolfa restored the ansible-dev branch May 21, 2021 14:00
hazayan pushed a commit to hazayan/void-packages that referenced this pull request Jun 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants