-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] linux-firmware: pull from commit hash instead of tag #31105
[RFC] linux-firmware: pull from commit hash instead of tag #31105
Conversation
a41ff02
to
497e521
Compare
I'm not sure. I think in general we prefer to stick to tags. |
497e521
to
c20eeae
Compare
I agree with @abenson. If we add this option in order to enable better hw support, I'd rather that the commit hash mode be optional, and we should always favor using the proper tags. Maybe something like |
firmware is one of the largest updates on some of my systems. Would be a bit annoying if it was constantly bumped. |
I really don't like grabbing arbitrary commits, which are much more likely to be buggy/unstable. Releases/tags generally exist for a reason, I don't see why linux-firmware is an exception. Also we generally don't package git master versions of packages. |
I do see |
We can also consider backporting important updates instead of pulling from commits: archlinux/svntogit-packages@efd0038 For example, this commit in Arch |
Can this be closed? This PR is very outdated and didn't get much approval either. |
This would enable faster support for new hardware, and avoid waiting for (possibly) two months just for
linux-firmware
to tag.One can ask for hardware support with firmware not tagged yet but present in master, and we can update the commit hash along with the date of the commit to pull in that new firmware.
General
Have the results of the proposed changes been tested?