Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] linux-firmware: pull from commit hash instead of tag #31105

Conversation

noarchwastaken
Copy link
Contributor

@noarchwastaken noarchwastaken commented May 25, 2021

This would enable faster support for new hardware, and avoid waiting for (possibly) two months just for linux-firmware to tag.

One can ask for hardware support with firmware not tagged yet but present in master, and we can update the commit hash along with the date of the commit to pull in that new firmware.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@noarchwastaken noarchwastaken force-pushed the linux-firmware-20210518 branch 2 times, most recently from a41ff02 to 497e521 Compare May 25, 2021 02:11
@abenson
Copy link
Contributor

abenson commented May 25, 2021

I'm not sure. I think in general we prefer to stick to tags.

@ericonr
Copy link
Member

ericonr commented May 25, 2021

I agree with @abenson. If we add this option in order to enable better hw support, I'd rather that the commit hash mode be optional, and we should always favor using the proper tags. Maybe something like _commit=$version and optionally one can change _commit=commit_hash.

@CameronNemo
Copy link
Contributor

firmware is one of the largest updates on some of my systems. Would be a bit annoying if it was constantly bumped.

@fosslinux
Copy link
Contributor

I really don't like grabbing arbitrary commits, which are much more likely to be buggy/unstable. Releases/tags generally exist for a reason, I don't see why linux-firmware is an exception. Also we generally don't package git master versions of packages.

@noarchwastaken
Copy link
Contributor Author

I really don't like grabbing arbitrary commits, which are much more likely to be buggy/unstable. Releases/tags generally exist for a reason, I don't see why linux-firmware is an exception. Also we generally don't package git master versions of packages.

I do see linux-firmware to be an exception though, it's simply a collection of non-free blobs, and it doesn't seem like that there's a "stabilizing" process anywhere.

@noarchwastaken
Copy link
Contributor Author

We can also consider backporting important updates instead of pulling from commits:

archlinux/svntogit-packages@efd0038

For example, this commit in Arch linux-firmware backports a bluetooth fix (apparently), enables support for RX 6700 series GPU (which many may buy because there's no choice today anyways) and a computing chip from AMD.

@tibequadorian
Copy link
Contributor

Can this be closed? This PR is very outdated and didn't get much approval either.

@paper42 paper42 closed this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants