Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontmanager: update to 0.8.7 + minor fixes #32683

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

meator
Copy link
Contributor

@meator meator commented Aug 26, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@meator meator changed the title fontmanager: update to 0.8.7 + add library to common/shlibs [WIP] fontmanager: update to 0.8.7 + add library to common/shlibs Aug 26, 2021
@meator meator force-pushed the font-manager branch 2 times, most recently from e4c3306 to 0fc4dfb Compare August 27, 2021 06:56
@meator meator changed the title [WIP] fontmanager: update to 0.8.7 + add library to common/shlibs fontmanager: update to 0.8.7 + minor fixes Aug 27, 2021
@Chocimier
Copy link
Member

Please squash.

common/shlibs Outdated Show resolved Hide resolved
revision=1
wrksrc="font-manager-${version}"
build_helper=gir
build_style=meson
hostmakedepends="pkg-config yelp-tools vala-devel glib-devel gettext"
makedepends="json-glib-devel sqlite-devel gtk+3-devel fontconfig-devel
libsoup-devel webkit2gtk-devel"
short_desc="Simple font management for GTK+ desktop environments"
short_desc="Font-manager is a simple font management tool for GTK+ environments"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package name shouldn/t be included in desc.

Copy link
Contributor Author

@meator meator Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do this to make searching for this package simpler. There is a little unfortunate inconsistency between the Voidlinux package name and the actual package name (Voidlinux uses fontmanager and practically every other package manager uses the official name font-manager). This change change costs basically nothing and it makes font-manager searchable via xbpq-query -Rs font-manager. If you do not agree with me, I will remove this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, okay.

@meator
Copy link
Contributor Author

meator commented Aug 30, 2021

About the squashing, I wasn't sure how should I format the commit message, since these changes don't fit in any of categories listed in CONTRIBUTING.md, so I made multiple commits. I'll fix this soon.

This commit adds "font-config" to the description of the package, in
order to make searching by real package name (xbps-query -Rs
font-manager) possible.
@Chocimier
Copy link
Member

You can use message body for things over simple update.

@Chocimier Chocimier merged commit 2adf7e0 into void-linux:master Aug 30, 2021
@meator meator deleted the font-manager branch August 31, 2021 08:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants