-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fontmanager: update to 0.8.7 + minor fixes #32683
Conversation
e4c3306
to
0fc4dfb
Compare
Please squash. |
revision=1 | ||
wrksrc="font-manager-${version}" | ||
build_helper=gir | ||
build_style=meson | ||
hostmakedepends="pkg-config yelp-tools vala-devel glib-devel gettext" | ||
makedepends="json-glib-devel sqlite-devel gtk+3-devel fontconfig-devel | ||
libsoup-devel webkit2gtk-devel" | ||
short_desc="Simple font management for GTK+ desktop environments" | ||
short_desc="Font-manager is a simple font management tool for GTK+ environments" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package name shouldn/t be included in desc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do this to make searching for this package simpler. There is a little unfortunate inconsistency between the Voidlinux package name and the actual package name (Voidlinux uses fontmanager
and practically every other package manager uses the official name font-manager
). This change change costs basically nothing and it makes font-manager searchable via xbpq-query -Rs font-manager
. If you do not agree with me, I will remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, okay.
About the squashing, I wasn't sure how should I format the commit message, since these changes don't fit in any of categories listed in |
This commit adds "font-config" to the description of the package, in order to make searching by real package name (xbps-query -Rs font-manager) possible.
You can use message body for things over simple update. |
General
Have the results of the proposed changes been tested?