Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-completion: complete tar with xbps files #35201

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

tornaria
Copy link
Contributor

Backported from upstream scop/bash-completion#688

Testing the changes

  • I tested the changes in this PR: YES

@tornaria
Copy link
Contributor Author

Just FTR, the failed tests are exactly the same with or without the patch that this PR introduces:

=========================== short test summary info ============================
FAILED test_aclocal.py::TestAclocal::test_1 - assert <CompletionResult []>
FAILED test_chsh.py::TestChsh::test_2 - assert <CompletionResult []>
FAILED test_ether_wake.py::TestEtherWake::test_1 - assert <CompletionResult []>
FAILED test_gdb.py::TestGdb::test_2 - AssertionError: assert <CompletionRe......
FAILED test_ifdown.py::TestIfdown::test_1 - assert <CompletionResult []>
FAILED test_ifstat.py::TestIfstat::test_2 - assert <CompletionResult []>
FAILED test_ifup.py::TestIfup::test_1 - assert <CompletionResult []>
FAILED test_iperf.py::TestIperf::test_2 - assert <CompletionResult []>
FAILED test_killall.py::TestKillall::test_1 - assert <CompletionResult []>
FAILED test_nethogs.py::TestNethogs::test_1 - assert <CompletionResult []>
FAILED test_perldoc.py::TestPerldoc::test_1 - AssertionError: assert 'Path' i...
FAILED test_perldoc.py::TestPerldoc::test_3 - AssertionError: assert <Complet...
FAILED test_pgrep.py::TestPgrep::test_1 - assert <CompletionResult []>
FAILED test_pidof.py::TestPidof::test_1 - assert <CompletionResult []>
FAILED test_pkill.py::TestPkill::test_1 - assert <CompletionResult []>
FAILED test_pwdx.py::TestPwdx::test_1 - assert <CompletionResult []>
FAILED test_renice.py::TestRenice::test_1 - assert <CompletionResult []>
FAILED test_renice.py::TestRenice::test_2 - assert <CompletionResult []>
FAILED test_reptyr.py::TestReptyr::test_1 - assert <CompletionResult []>
FAILED test_service.py::TestService::test_1 - assert <CompletionResult []>
FAILED test_tar.py::TestTar::test_4 - AssertionError: assert <CompletionResul...
FAILED test_tar.py::TestTar::test_22 - AssertionError: assert <CompletionResu...
FAILED unit/test_unit_ip_addresses.py::TestUnitIpAddresses::test_1 - Assertio...
FAILED unit/test_unit_ip_addresses.py::TestUnitIpAddresses::test_2 - assert <...
FAILED unit/test_unit_ip_addresses.py::TestUnitIpAddresses::test_3 - assert <...
FAILED unit/test_unit_ip_addresses.py::TestUnitIpAddresses::test_4 - assert <...
= 26 failed, 1106 passed, 457 skipped, 14 xfailed, 4 xpassed in 1126.01s (0:18:46) =

I'd rather wait for the next upstream release to worry about tests passing.

@paper42
Copy link
Member

paper42 commented Jan 23, 2022

Just FTR, the failed tests are exactly the same with or without the patch that this PR introduces:

I'd rather wait for the next upstream release to worry about tests passing.

Let's disable them with a FIXME comment

@tornaria
Copy link
Contributor Author

Let's disable them with a FIXME comment

With the idea of #34766 I would annotate this as check_xfail="*" so the checks run but the error is ignored.

srcpkgs/bash-completion/template Outdated Show resolved Hide resolved
srcpkgs/bash-completion/template Outdated Show resolved Hide resolved
Backported from upstream scop/bash-completion#688

Fix checkdepends so tests run, deselect 26 tests that fail atm,
with the goal of fixing this for next release 2.12.

Also conditionally deselect a couple of tests that fail only on CI.
@tornaria
Copy link
Contributor Author

@paper42 should be ok now, both local and CI pass.

@paper42 paper42 merged commit 64571d4 into void-linux:master Jan 24, 2022
@tornaria tornaria deleted the complete-xbps branch January 25, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants