mpv-mpris: update to 0.6 #35592
Closed
mpv-mpris: update to 0.6 #35592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a fan of putting binaries in /etc, also would probably break current users of the package who load the plugin by configuring mpv. |
|
Would it make sense to make a link in |
The mpv-mpris makefile installs it to /var/lib, but also creates a link in /etc/mpv/scripts, so I think we should follow that. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
I also updated the install directory to
etc/mpv/scriptsas stated in the package homepage is where mpv actually looks for scripts. It was not being located properly in/usr/lib/mpv-mpris.