Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbps-src: don't export CCACHE_COMPRESS=1 #38986

Closed
wants to merge 1 commit into from
Closed

xbps-src: don't export CCACHE_COMPRESS=1 #38986

wants to merge 1 commit into from

Conversation

r-ricci
Copy link
Contributor

@r-ricci r-ricci commented Aug 30, 2022

ccache enables compression by default since version 4.0.
This variable is redundant and prevents disabling compression through
a config file (useful e.g. on compressed filesystems).

AFAIK there's no way to disable compression when CCACHE_COMPRESS is present, since the environment has the highest precedence, according to the manual:

The priorities of configuration options are as follows (where 1 is highest):

 1. Environment variables.

 2. The primary (cache-specific) configuration file (see below).

 3. The secondary (system-wide read-only) configuration file
     <sysconfdir>/ccache.conf (typically /etc/ccache.conf or
     /usr/local/etc/ccache.conf).

 5. Compile-time defaults.

Testing the changes

  • I tested the changes in this PR: YES

@classabbyamp classabbyamp added the xbps-src xbps-src related label Aug 30, 2022
@@ -679,7 +679,7 @@ if [ "$XBPS_CCACHE" ]; then
export CCACHE_DIR="$XBPS_HOSTDIR/ccache"
# Avoid not using cached files just due to compiler mtime
# changes when e.g. bootstrapping
export CCACHE_COMPILERCHECK=content CCACHE_COMPRESS=1
export CCACHE_COMPILERCHECK=content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but something like:

    if [ -z "${XBPS_CCACHE_NOCOMPRESS+set}" ]; then
        export CCACHE_COMPRESS=1
    fi

with XBPS_CCACHE_NOCOMPRESS from config file.

Disable ccache compression is NOT nice.

@r-ricci
Copy link
Contributor Author

r-ricci commented Aug 31, 2022 via email

ccache enables compression by default since version 4.0.
This variable is redundant and prevents disabling compression through
a config file (useful e.g. on compressed filesystems).
@r-ricci r-ricci closed this Nov 20, 2022
@r-ricci r-ricci deleted the ccache-compress branch November 20, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
xbps-src xbps-src related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants