-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptsetup: update to 2.5.0. #39446
cryptsetup: update to 2.5.0. #39446
Conversation
68b0135
to
4c2ee1c
Compare
srcpkgs/cryptsetup/template
Outdated
checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507 | ||
make_check=extended | ||
checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542 | ||
make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests fail in local builds too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied below, but if you want I can add the make_check=no because they require root to run and are skipped locally.
=======================
All 9 tests passed
(22 tests were not run)
=======================
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ grep CHECK etc/conf
XBPS_CHECK_PKGS=full
$ ./xbps-src binary-bootstrap x86_64-musl && ./xbps-src pkg cryptsetup
...
FAIL: luks2-reencryption-mangle-test
WARNING: You must be root to run this test, test skipped.
SKIP: verity-compat-test
WARNING: You must be root to run this test, test skipped.
SKIP: integrity-compat-test
WARNING: You must be root to run this test, test skipped.
SKIP: ssh-test-plugin
=======================
2 of 10 tests failed
(21 tests were not run)
=======================
make[2]: *** [Makefile:900: check-TESTS] Error 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reported upstream (https://gitlab.com/cryptsetup/cryptsetup/-/issues/781)
Are you okay with adding make_check=no if libc is musl on the template ?
Yeah with CI I meant the chroot ...
Not sure if the failure is the same reason, let me check
Strike that, the tests that needs to be run as root locally are skipped at least on my x86_64-glibc.
=======================
All 9 tests passed
(22 tests were not run)
=======================
…On 22/10/17 02:08PM, Piraty wrote:
@Piraty commented on this pull request.
> @@ -16,8 +16,8 @@ license="GPL-2.0-or-later"
homepage="https://gitlab.com/cryptsetup/cryptsetup"
changelog="https://gitlab.com/cryptsetup/cryptsetup/raw/master/docs/v${version}-ReleaseNotes"
distfiles="${KERNEL_SITE}/utils/cryptsetup/v${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=fc0df945188172264ec5bf1d0bda08264fadc8a3f856d47eba91f31fe354b507
-make_check=extended
+checksum=9184a6ebbd9ce7eb211152e7f741a6c82f2d1cc0e24a84ec9c52939eee0f0542
+make_check=ci-skip # tests depend on acessing /dev/mapper/control fails on CI
some tests fail in local builds too
--
Reply to this email directly or view it on GitHub:
#39446 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
04f35b6
to
f68c618
Compare
I'd prefer we use |
f68c618
to
060c57c
Compare
Thanks, I am pretty sure that enabling |
Testing the changes
I have also went ahead and compiled it on a VM with musl glibc (x86_64-musl) and cross compiled it with armv6l.
Local build testing
Probably should be marked as tests needed as other people might have different setups than mine. ( and this update broke something).