Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: ffmpeg to 5.1.2 [Draft] #41470

Closed
wants to merge 1 commit into from
Closed

Conversation

absrd
Copy link
Contributor

@absrd absrd commented Jan 5, 2023

Testing the changes

  • I tested the changes in this PR: YES

@Danoloan10
Copy link
Contributor

This package has so many dependencies (grep "depends=.*ffmpeg" srcpkgs/**/template | wc -l gives 12000+). And this update is quite breaking apparently. How should we go on about verifying the update? Should a new ffmpeg4 package be introduced while transitioning?

@icp1994
Copy link
Contributor

icp1994 commented Jan 6, 2023

Excluding symlinks, we don't even have 12k total templates!

#36315 has significant work regarding this.

@Danoloan10
Copy link
Contributor

That's right, didn't think about the symlinks... That PR has some impressive work. There many broken dependencies yet :(

@Johnnynator
Copy link
Member

The xrevshlib tool in xtools can be used to find all the packages that do link against ffmpeg (or one of its subpackages).

@motorto
Copy link
Contributor

motorto commented Jan 31, 2023

Would it be acceptable to create an ffmpeg4.4 package and a ffmpeg (that tracks the upstream version) ?

This would make it possible to update the ffmpeg, and the packages that don't build with 5.0 uses the 4.4 package.

@Johnnynator @paper42

@milgra
Copy link

milgra commented Mar 5, 2023

Hi, my programs also need ffmpeg5 so it would be nice if we could make this work. What about creating an ffmpeg5 package so nothing breaks? I don't know what to put into common/shlibs in that case though.

@paper42
Copy link
Member

paper42 commented Mar 5, 2023

This PR is failing all checks, is missing a lot of revbumps and didn't get any attention from the author since it was opened. If anyone is interested in continuing this work, please open a new PR and base it on @tibequadorian's work linked above which was way more complete and wasn't just a simple revbump (which this update definitely isn't).

It would be acceptable to have a ffmpeg4 package and switch all packages that don't work with ffmpeg 5 to it if:

  • there are important packages that don't work with ffmpeg 5 and can not be made to work with ffmpeg 5 reliably
  • at the same time, ffmpeg is updated to v5 and all packages that work with it get rebuilt for ffmpeg (5)

@paper42 paper42 marked this pull request as draft March 6, 2023 19:47
@zlice
Copy link
Contributor

zlice commented Mar 19, 2023

It would be acceptable to have a ffmpeg4 package and switch all packages that don't work with ffmpeg 5 to it if ...

Have an example package of how this works? I see mlt(6) and mlt7 but I'm not seeing where the binary becomes melt vs melt-7 unless it's in makefiles or something.

@icp1994
Copy link
Contributor

icp1994 commented Mar 19, 2023

wlroots

@zlice
Copy link
Contributor

zlice commented Mar 19, 2023

What about something with a binary(ies)?

edit: i guess i should specify, something in /bin, not a library

@icp1994
Copy link
Contributor

icp1994 commented Mar 19, 2023

lua

@paper42
Copy link
Member

paper42 commented Mar 19, 2023

lua

lua uses versioned packages (lua51, lua52, etc.) and the lua package is just an transitional empty package pointing to one version for backwards compatibility

@zlice
Copy link
Contributor

zlice commented Mar 19, 2023

lua uses versioned packages ...

will splitting ffmpeg to 4 and 5 with 'alternatives' like lua and php not work then?

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 18, 2023
@github-actions github-actions bot closed this Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants