added mixmaster as a build option to the neomutt template #42193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paper42
reviewed
Feb 10, 2023
srcpkgs/neomutt/template
Outdated
Comment on lines
44
to
49
| do_configure() { | ||
| if [ "$build_option_mixmaster" ]; then | ||
| configure_args+=" --mixmaster" | ||
| fi | ||
| ./configure ${configure_args} | ||
| } |
There was a problem hiding this comment.
Suggested change
| do_configure() { | |
| if [ "$build_option_mixmaster" ]; then | |
| configure_args+=" --mixmaster" | |
| fi | |
| ./configure ${configure_args} | |
| } | |
| if [ "$build_option_mixmaster" ]; then | |
| configure_args+=" --mixmaster" | |
| fi |
terminaldweller
force-pushed
the
master
branch
from
7c6cd3d
to
7c6bfbf
Compare
|
done |
|
and squash the commits, it should be one per package cc maintainer @Vaelatern |
|
I suspect this will be enabled by default next release. Do you think that is the case too? |
It is one commit now. at least it says so at the top. is that acceptable? |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
mixmaster is kinda dead so it doesn't add much to have this enabled by default so I'm closing this. feel free to re-open if anyone disagrees. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes