Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: update to 23.0.3. #42407

Closed
wants to merge 1 commit into from
Closed

mesa: update to 23.0.3. #42407

wants to merge 1 commit into from

Conversation

ardadem
Copy link
Contributor

@ardadem ardadem commented Feb 23, 2023 •
edited
Loading

Testing the changes

  • I tested the changes in this PR: YES (currently)

Draft until next stable release.

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Apr 1, 2023 •
edited
Loading

Please set [ci skip] in the description for now, repo-default is currently experiencing a hiccup and results in packages rebuilding LLVM in CI

@ardadem ardadem force-pushed the pr-mesa-23.0 branch 2 times, most recently from e16fb6e to c70ee10 Compare April 1, 2023 12:35
@ardadem ardadem changed the title [NOMERGE] mesa: update to 23.0.0. mesa: update to 23.0.1. Apr 1, 2023
@ardadem ardadem force-pushed the pr-mesa-23.0 branch 2 times, most recently from 6632946 to 1caa9a0 Compare April 3, 2023 11:06
@ardadem ardadem marked this pull request as ready for review April 3, 2023 11:57
@ardadem ardadem force-pushed the pr-mesa-23.0 branch 2 times, most recently from 42b59c0 to ac2c3cd Compare April 8, 2023 14:35
@ardadem ardadem changed the title mesa: update to 23.0.1. mesa: update to 23.0.2. Apr 8, 2023
@ardadem ardadem marked this pull request as draft April 8, 2023 14:41
@ardadem ardadem marked this pull request as ready for review April 15, 2023 10:35
triallax
triallax suggested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@triallax triallax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 23.0.1 with 23.0.2 in the commit message. Also, the description doesn't seem to fit the package, is it a holdover from when the package was named libGL? Shouldn't it be updated?

Otherwise, I tested this locally with no issues.

srcpkgs/mesa/template
build_style=meson
configure_args="-Dglvnd=true -Dshared-glapi=enabled -Dgbm=enabled -Degl=enabled
-Dosmesa=true -Dgles1=enabled -Dgles2=enabled -Dglx=dri -Ddri3=enabled
-Dlmsensors=enabled -Dplatforms=x11$(vopt_if wayland ,wayland)
-Dllvm=enabled -Db_lto=false -Dcpp_std=gnu++14"
-Dllvm=enabled -Db_lto=false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built and tested this locally without -Db_lto=false, didn't notice any issues whatsoever:

Suggested change
-Dllvm=enabled -Db_lto=false"
-Dllvm=enabled"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#41084 (comment)

Copy link
Contributor

@triallax triallax Apr 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'd add a comment above configure_args to clarify the reason this is needed, something like # Disable LTO because of https://gitlab.freedesktop.org/mesa/mesa/-/issues/6911.

@ardadem ardadem force-pushed the pr-mesa-23.0 branch 2 times, most recently from db695fc to e8534e1 Compare April 18, 2023 07:00
@HadetTheUndying
Copy link
Contributor

HadetTheUndying commented Apr 25, 2023 •
edited
Loading

Has anyone else been testing this? I've not had any problems with it over the last 4 days that aren't already present bugs in Mesa with RDNA2.

EDIT: Also 23.0.3 is available now.

@baal-zebub
Copy link
Contributor

Has anyone else been testing this?

I'd love to but I'm getting this error when executing ./xbps-src pkg mesa:

=> cmake-3.25.3_1: running do_build ...
[1/68] sphinx-build man: see Utilities/Sphinx/build-man.log
FAILED: Utilities/Sphinx/doc_format_man /builddir/cmake-3.25.3/build/Utilities/Sphinx/doc_format_man 
cd /builddir/cmake-3.25.3/build/Utilities/Sphinx && /usr/bin/sphinx-build -c /builddir/cmake-3.25.3/build/Utilities/Sphinx -d /builddir/cmake-3.25.3/build/Utilities/Sphinx/doctrees -b man /builddir/cmake-3.25.3/Help /builddir/cmake-3.25.3/build/Utilities/Sphinx/man > build-man.log
Traceback (most recent call last):
  File "/usr/bin/sphinx-build", line 5, in <module>
    from sphinx.cmd.build import main
ModuleNotFoundError: No module named 'sphinx'

@JamiKettunen
Copy link
Contributor

That's not even an error related to mesa build, rebase the PR branch on top of latest void-packages master always when trying stuff like this, otherwise it tries to build older versions of packages no longer in repo etc.

@ardadem ardadem changed the title mesa: update to 23.0.2. mesa: update to 23.0.3. Apr 27, 2023
@zlice
Copy link
Contributor

zlice commented Apr 29, 2023

Has anyone else been testing this?

I'd love to but I'm getting this error when executing ./xbps-src pkg mesa:

=> cmake-3.25.3_1: running do_build ...
[1/68] sphinx-build man: see Utilities/Sphinx/build-man.log
FAILED: Utilities/Sphinx/doc_format_man /builddir/cmake-3.25.3/build/Utilities/Sphinx/doc_format_man 
cd /builddir/cmake-3.25.3/build/Utilities/Sphinx && /usr/bin/sphinx-build -c /builddir/cmake-3.25.3/build/Utilities/Sphinx -d /builddir/cmake-3.25.3/build/Utilities/Sphinx/doctrees -b man /builddir/cmake-3.25.3/Help /builddir/cmake-3.25.3/build/Utilities/Sphinx/man > build-man.log
Traceback (most recent call last):
  File "/usr/bin/sphinx-build", line 5, in <module>
    from sphinx.cmd.build import main
ModuleNotFoundError: No module named 'sphinx'

If you're still having issues, I'd clear masterdir and redo binary bootstrap, make sure git is updated and any hostdir/binpkgs aren't polluted with something that may want a different version of sphinx or something like that.

@zlice
Copy link
Contributor

zlice commented Apr 29, 2023

Has anyone else been testing this? I've not had any problems with it over the last 4 days that aren't already present bugs in Mesa with RDNA2.

Been flipping between mesa dev and Intel's DG2 branches. Only issue's I've had are flickering because they enabled some RADV buffer/texture waits by default.

@HadetTheUndying
Copy link
Contributor

I haven't had any issues but both of my Void systems are Vega and Polaris.

@kenrap
Copy link
Contributor

kenrap commented Apr 30, 2023

I've been testing 23.0.3 for about 5 days now, before it got verbump'd here, with my Intel Arc A770 card while using linux6.2. I haven't had much issues while using KDE Wayland. I'm also looking forward to the eventual 23.1.0 release since it's already in rc3 atm.

@HadetTheUndying
Copy link
Contributor

Just an update I've tested this PR on all of my machines including my Steam Deck without issues now so I'm pretty certain there are no issues with the PR that aren't already being tracked in the upstream.

@kenrap
Copy link
Contributor

kenrap commented May 11, 2023

Mesa 23.1.0 has now been officially released on their Gitlab.

@Mek101
Copy link
Contributor

Mek101 commented May 16, 2023

Built without an issue

@biopsin
Copy link
Contributor

biopsin commented May 17, 2023

Mesa 23.1.0 tests fine on glibc and Radeon RX570 playing games ..
Also meson_build_ options have change to _dri_drivers=" -Ddri-drivers-path="

@HadetTheUndying
Copy link
Contributor

Mesa 23.1.0 has now been officially released on their Gitlab.

Void always waits for the first stable release which would be 23.1.1

@saltnpepper97
Copy link

saltnpepper97 commented May 19, 2023 •
edited
Loading

Please close this 23.0.3 It is really needed for AMD 7900 xtx cards at the moment. There is a bug with the current version of meaa and xf86-video-amdgpu for us causing some issues with the cursor but also I have noticed screen recognition on awesome wm.

Also please update xf86-video-amdgpu to 23.0.0

@JamiKettunen
Copy link
Contributor

@saltnpepper97 You probably should stop using xf86-video-amdgpu, all modern GPUs should use the modesetting (KMS) driver that's bundled with xorg-server itself; I'm using it just fine on i3wm with an RX 6600.

@saltnpepper97
Copy link

So I should have installed xorg-minimal? Because xorg package group by default installs xf86-video-amdgpu...

@saltnpepper97
Copy link

Also how is a package as important as mesa marked as orphaned?

@triallax
Copy link
Contributor

Also how is a package as important as mesa marked as orphaned?

A package's importance has no bearing on its maintenance status (which itself isn't that important by the way).

@saltnpepper97
Copy link

Sorry, I guess I dont understand package maintenace that well.

However I will just say that this driver version 23.0.3 works way better for my card as xrandr is not detecting things properly at the moment on the current mesa version for me.

@saltnpepper97
Copy link

Also, I could maintain some packages if you guys would like that...

@HadetTheUndying
Copy link
Contributor

Recommend joining the #voidlinux and #xbps channels on Libera to discuss that.

@SpidFightFR
Copy link
Contributor

Also how is a package as important as mesa marked as orphaned?

from what i understood: a package having a maintainer just is a way to redirect people to a person if they have a problem with the package. But in reality, it shouldn't impact the update frequency of the package.

@saltnpepper97
Copy link

Also how is a package as important as mesa marked as orphaned?

from what i understood: a package having a maintainer just is a way to redirect people to a person if they have a problem with the package. But in reality, it shouldn't impact the update frequency of the package.

Thanks for the clarification. 👍

@HadetTheUndying
Copy link
Contributor

Mesa 23.1.1 just got released.

@JamiKettunen JamiKettunen mentioned this pull request May 30, 2023
Merged
@ardadem
Copy link
Contributor Author

ardadem commented Jun 2, 2023

Superseded by #44138.

@ardadem ardadem closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triallax triallax triallax requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.