Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-pylast: update to 5.1.0. #43161

Closed
wants to merge 1 commit into from

Conversation

Luc-Saccoccio
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: *YES

@nekopsykose
Copy link

python3-importlib_metadata is only for python versions below 3.8 (by dep declaration in pyproject.toml), so not the case here and isn't needed

@paper42
Copy link
Member

paper42 commented Apr 12, 2023

did you test if packages which depend on pylast still work?

checksum=ad084aec1bf7e307bc42d7cc1a003851f5bee1ad24fb697a9fdc300bbfe63932
make_check=no # The 'pylast' distribution was not found and is required by the application
checksum=89300fdcdf423d7be0606bdc44da27c3b48c4d73aa1d4cb12672cc006c979bdc
make_check=no # Unable to determine tests for PEP517 Python templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a harmless warning, there should be no reason to explicitly disable tests, also, we can run at least some tests, it's currently ugly, but it works.

checkdepends="python3-pytest python3-flaky ${depends}"
do_check() {
       rm -rf tmp # remove artifacts from previous unsuccessful check run
       mkdir tmp
       bsdtar xf dist/pylast-$version-py3-none-any.whl -C tmp
       PYTHONPATH=tmp pytest
       rm -rf tmp
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now when #42013 has been merged, you can leave out the do_check function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants