Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: electron24-24.2.0 #43754

Merged
merged 1 commit into from
May 8, 2023
Merged

New package: electron24-24.2.0 #43754

merged 1 commit into from
May 8, 2023

Conversation

Johnnynator
Copy link
Member

Testing the changes

  • I tested the changes in this PR: NO

resolves #43744

[ci skip]
[skip ci]

@atk
Copy link
Contributor

atk commented May 5, 2023

I get an error when I try to build this: /void-packages/srcpkgs/electron24/template: line 114: cd: /builddir/electron24-24.2.0//builddir/electron24-24.2.0/src/electron: No such file or directory

@Johnnynator
Copy link
Member Author

Remove the $wrksrc in the 2nd _git_init invocation. It should build fine for glibc after that. The musl should still fail.

@atk
Copy link
Contributor

atk commented May 5, 2023

Thanks, but now I get

[316/45916] ACTION //chrome/common/extensions/api:generated_api_json_strings_bundle_generator_schema(//build/toolchain/linux/unbundle:default)
ninja: build stopped: subcommand failed.
=> ERROR: electron24-24.2.0_1: do_build: 'ninja ${makejobs} -C out/$_buildtype electron third_party/electron_node:headers' exited with 1
=> ERROR:   in do_build() at srcpkgs/electron24/template:412

@Johnnynator
Copy link
Member Author

argh I did accidently push to the wrong remote, so the current commit did miss more than only the one thing I rememberd out of my head. I pushed my current version. glibc build is done (see link), musl is still running


https://void.johnnynator.dev/current/x86_64/electron24-24.2.0_1.x86_64.xbps

@Johnnynator
Copy link
Member Author

@atk do you have an updated vscode template, would like to test the musl build proper before merging.

@atk
Copy link
Contributor

atk commented May 6, 2023

You can just increase the version and remove the ffmpeg-download patch, as it is no longer necessary. I'm currently on my mobile without access to my work station.

@Johnnynator
Copy link
Member Author

I just get a 404, but nut sure what it is trying to fetch

[09:58:47] 'vscode-linux-x64-min' errored after 4.63 min
[09:58:47] HTTPError: Response code 404 (Not Found)
    at Request._onResponseBase (/builddir/vscode-1.78.0/node_modules/got/dist/source/core/index.js:913:31)
    at Request._onResponse (/builddir/vscode-1.78.0/node_modules/got/dist/source/core/index.js:948:24)
    at ClientRequest.<anonymous> (/builddir/vscode-1.78.0/node_modules/got/dist/source/core/index.js:962:23)
    at Object.onceWrapper (node:events:628:26)
    at ClientRequest.emit (node:events:525:35)
    at ClientRequest.emit (node:domain:552:15)
    at ClientRequest.origin.emit (/builddir/vscode-1.78.0/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
    at HTTPParser.parserOnIncomingClient (node:_http_client:693:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
    at TLSSocket.socketOnData (node:_http_client:534:22)
error Command failed with exit code 1.

@atk
Copy link
Contributor

atk commented May 6, 2023

Thanks for the info, I'll have a look later.

@Johnnynator Johnnynator marked this pull request as ready for review May 6, 2023 12:18
@classabbyamp classabbyamp added the new-package This PR adds a new package label May 7, 2023
@Johnnynator Johnnynator merged commit c9843a7 into master May 8, 2023
@Johnnynator Johnnynator deleted the electron24 branch May 8, 2023 16:53
@atk
Copy link
Contributor

atk commented May 8, 2023

Sorry for the delay, had a water leakage in my cellar and thus no time to test things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: electron24
3 participants