-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: electron24-24.2.0 #43754
Conversation
I get an error when I try to build this: /void-packages/srcpkgs/electron24/template: line 114: cd: /builddir/electron24-24.2.0//builddir/electron24-24.2.0/src/electron: No such file or directory |
Remove the $wrksrc in the 2nd _git_init invocation. It should build fine for glibc after that. The musl should still fail. |
Thanks, but now I get [316/45916] ACTION //chrome/common/extensions/api:generated_api_json_strings_bundle_generator_schema(//build/toolchain/linux/unbundle:default)
ninja: build stopped: subcommand failed.
=> ERROR: electron24-24.2.0_1: do_build: 'ninja ${makejobs} -C out/$_buildtype electron third_party/electron_node:headers' exited with 1
=> ERROR: in do_build() at srcpkgs/electron24/template:412 |
argh I did accidently push to the wrong remote, so the current commit did miss more than only the one thing I rememberd out of my head. I pushed my current version. glibc build is done (see link), musl is still running https://void.johnnynator.dev/current/x86_64/electron24-24.2.0_1.x86_64.xbps |
@atk do you have an updated vscode template, would like to test the musl build proper before merging. |
You can just increase the version and remove the ffmpeg-download patch, as it is no longer necessary. I'm currently on my mobile without access to my work station. |
I just get a 404, but nut sure what it is trying to fetch
|
Thanks for the info, I'll have a look later. |
Sorry for the delay, had a water leakage in my cellar and thus no time to test things. |
Testing the changes
resolves #43744
[ci skip]
[skip ci]