Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: ayugram-desktop-4.9.4, ayugram-desktop-sysfont-4.9.4 #46248

Closed
wants to merge 2 commits into from
Closed

Conversation

incycledream
Copy link

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (ARCH-LIBC)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 25, 2023
@ahesford
Copy link
Member

Packages that just clone a git repository in do_fetch are not acceptable. A GitHub archive should be fetched properly.

The ayugram-desktop and ayugram-desktop-sysfont templates seem identical, at least as far as I can tell paging back and forth. What is the difference between them?

Use of broken= to disable unsupported archs is not appropriate. The archs variable should be used for proper architecture restrictions.

@incycledream
Copy link
Author

okay, I'll fix the mistakes. I used official telegram desktop template and I thought everything is okay
also, I forgot to specify that CI will take more than 2 hours due having two commits with different versions

about packages, version with sysfont ending is having system font. you can see by checking patches directory

void-packages/srcpkgs/ayugram-desktop/patches:
total 4.0K
   0 drwxr-xr-x 1 westpain westpain  54 Sep 25 17:16 .
   0 drwxr-xr-x 1 westpain westpain  30 Sep 25 17:16 ..
4.0K -rw-r--r-- 1 westpain westpain 419 Sep 25 17:16 0001-use-vendored-gsl.patch

void-packages/srcpkgs/ayugram-desktop-sysfont/patches:
total 8.0K
   0 drwxr-xr-x 1 westpain westpain  80 Sep 25 17:16 .
   0 drwxr-xr-x 1 westpain westpain  30 Sep 25 17:16 ..
4.0K -rw-r--r-- 1 westpain westpain 419 Sep 25 17:16 0001-use-vendored-gsl.patch
4.0K -rw-r--r-- 1 westpain westpain 352 Sep 25 17:16 sysfont.patch

@ahesford
Copy link
Member

Two packages that are the same except for a one-line patch to change the font are not acceptable.

@Johnnynator
Copy link
Member

https://core.telegram.org/api/terms

1.4. It is forbidden to interfere with the basic functionality of Telegram. This includes but is not limited to: making actions on behalf of the user without the user's knowledge and consent, preventing self-destructing content from disappearing, preventing last seen and online statuses from being displayed correctly, tampering with the 'read' statuses of messages (e.g. implementing a 'ghost mode'), preventing typing statuses from being sent/displayed, etc.

The API Access and therefore the used API Key hast to follow the API Terms of Use. Void has some basic responsibility to not ship software to users with the sole intention of breaking the TOU of a single Service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants