-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: system76-keyboard-configurator-1.3.10 #46610
Conversation
a7718f6
to
cf7e7e5
Compare
You need at least |
cf7e7e5
to
df77d89
Compare
@icp1994 Fixed |
@classabbyamp and @icp1994 Does this look now ok? |
Yes |
Any change getting this merged? |
version=1.3.10 | ||
revision=1 | ||
build_style=cargo | ||
hostmakedepends="pkg-config glib-devel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this links against glib-devel, shouldn't it be in makedepends?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it should be libglib-devel
in makedepends I think. You would still need the glib-devel
in hostmakedepends for cross-compiling as it tries to run /usr/bin/glib-compile-resources
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you forget to push the fix?
df77d89
to
5fdb84c
Compare
So any thoughts on this @classabbyamp @icp1994? |
ping @classabbyamp @icp1994 |
Is there still something I should do to get this merged @classabbyamp? |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
5fdb84c
to
1dd26fe
Compare
ping @classabbyamp @icp1994 |
1dd26fe
to
6fb5a4e
Compare
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing