Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: system76-keyboard-configurator-1.3.10 #46610

Closed
wants to merge 1 commit into from

Conversation

heppu
Copy link

@heppu heppu commented Oct 11, 2023

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, x86_64

@classabbyamp classabbyamp added the new-package This PR adds a new package label Oct 11, 2023
@heppu heppu force-pushed the new-pkg/keyboard-configurator branch from a7718f6 to cf7e7e5 Compare October 12, 2023 04:58
@icp1994
Copy link
Contributor

icp1994 commented Oct 12, 2023

You need at least glib-devel inside hostmakedepends.

@heppu heppu force-pushed the new-pkg/keyboard-configurator branch from cf7e7e5 to df77d89 Compare October 12, 2023 08:13
@heppu
Copy link
Author

heppu commented Oct 12, 2023

@icp1994 Fixed

@heppu
Copy link
Author

heppu commented Oct 16, 2023

@classabbyamp and @icp1994 Does this look now ok?

@icp1994
Copy link
Contributor

icp1994 commented Oct 16, 2023

Yes

@heppu
Copy link
Author

heppu commented Oct 24, 2023

Any change getting this merged?

version=1.3.10
revision=1
build_style=cargo
hostmakedepends="pkg-config glib-devel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this links against glib-devel, shouldn't it be in makedepends?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it should be libglib-devel in makedepends I think. You would still need the glib-devel in hostmakedepends for cross-compiling as it tries to run /usr/bin/glib-compile-resources.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forget to push the fix?

@heppu heppu force-pushed the new-pkg/keyboard-configurator branch from df77d89 to 5fdb84c Compare October 27, 2023 06:19
@heppu
Copy link
Author

heppu commented Nov 13, 2023

So any thoughts on this @classabbyamp @icp1994?

@heppu
Copy link
Author

heppu commented Nov 22, 2023

ping @classabbyamp @icp1994

@heppu
Copy link
Author

heppu commented Dec 19, 2023

Is there still something I should do to get this merged @classabbyamp?

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 19, 2024
@heppu heppu force-pushed the new-pkg/keyboard-configurator branch from 5fdb84c to 1dd26fe Compare March 19, 2024 08:27
@github-actions github-actions bot removed the Stale label Mar 20, 2024
@heppu
Copy link
Author

heppu commented Mar 25, 2024

ping @classabbyamp @icp1994

@heppu heppu force-pushed the new-pkg/keyboard-configurator branch from 1dd26fe to 6fb5a4e Compare May 20, 2024 06:11
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 19, 2024
@github-actions github-actions bot closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants