Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2: update to 2.12.5. #48826

Merged
merged 8 commits into from
Mar 6, 2024
Merged

libxml2: update to 2.12.5. #48826

merged 8 commits into from
Mar 6, 2024

Conversation

oreo639
Copy link
Member

@oreo639 oreo639 commented Feb 19, 2024

Testing the changes

  • I tested the changes in this PR: briefly

I tested building all packages depending on libxml2.
The only other build failure not addressed is vtk, which is gcc 13 related.
This depends on #48824

cc: @classabbyamp

@oreo639 oreo639 marked this pull request as draft February 19, 2024 05:24
@oreo639
Copy link
Member Author

oreo639 commented Feb 19, 2024

It was reported in #47473 that s3fs-fuse fails to build with libmxl2 2.12 but I can't reproduce this with 2.12.5.

@sgn
Copy link
Member

sgn commented Feb 19, 2024

php/php-src@0a39890

@oreo639
Copy link
Member Author

oreo639 commented Feb 19, 2024

php/php-src@0a39890

Seems like their tests are configured with --enable-werror, which we don't do, and implicitly casing away a const is a warning in clang since 2015 (whereas no such warning exists in gcc).

Should I import that patch?

@sgn
Copy link
Member

sgn commented Feb 19, 2024

I would push all fixes first, instead of leave those commits sits in the pr.

@oreo639
Copy link
Member Author

oreo639 commented Feb 19, 2024

Regarding s3fs-fuse, seems like that was fixed by libxml2 upstream for 2.12.2/2.12.3 https://gitlab.gnome.org/GNOME/libxml2/-/issues/642
(php8.1 also builds fine without any extra patching for example, which I assume is also a result of them re-arranging the #define s)

@oreo639 oreo639 force-pushed the libxml2 branch 4 times, most recently from 9df4ec6 to 5d82e54 Compare February 25, 2024 03:45
@oreo639 oreo639 marked this pull request as ready for review February 25, 2024 03:48
@oreo639 oreo639 force-pushed the libxml2 branch 3 times, most recently from 8a1a4d6 to 767eba1 Compare February 27, 2024 02:39
@oreo639 oreo639 merged commit b500f20 into void-linux:master Mar 6, 2024
7 of 8 checks passed
@oreo639 oreo639 deleted the libxml2 branch March 6, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants