Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2: update to 2.12.1. #47473

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

triallax
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@leahneukirchen
Copy link
Member

musl tests were broken before.

@Duncaen Duncaen merged commit 35f385c into void-linux:master Dec 1, 2023
7 of 8 checks passed
@classabbyamp
Copy link
Member

reverted: 343da92

breaks inkscape build:

../src/object/uri.cpp: In constructor 'Inkscape::URI::URI(const gchar*, const char*)':
../src/object/uri.cpp:86:9: error: 'xmlFree' was not declared in this scope; did you mean 'xmlFreeURI'?
   86 |         xmlFree(full);
      |         ^~~~~~~
      |         xmlFreeURI
../src/object/uri.cpp:89:9: error: 'xmlFree' was not declared in this scope; did you mean 'xmlFreeURI'?
   89 |         xmlFree(escaped);
      |         ^~~~~~~
      |         xmlFreeURI
../src/object/uri.cpp: In member function 'std::string Inkscape::URI::str(const char*) const':
../src/object/uri.cpp:292:9: error: 'xmlFree' was not declared in this scope; did you mean 'xmlFreeURI'?
  292 |         xmlFree(saveuri);
      |         ^~~~~~~
      |         xmlFreeURI

@triallax triallax deleted the libxml2-2.12.1 branch December 2, 2023 14:32
@triallax
Copy link
Contributor Author

triallax commented Dec 2, 2023

Oops, I'll take a look at it later

@leahneukirchen
Copy link
Member

Fix for inkscape:

--- a/src/object/uri.h
+++ b/src/object/uri.h
@@ -13,6 +13,7 @@
 #define INKSCAPE_URI_H
 
 #include <libxml/uri.h>
+#include <libxml/xmlmemory.h>
 #include <memory>
 #include <string>
 

@leahneukirchen
Copy link
Member

s3fs-fuse has similar issues, and needs <libxml/xmlmemory.h> and <libxml/parser.h>.

@triallax
Copy link
Contributor Author

triallax commented Dec 3, 2023

I did some mass builds, the bump breaks at least dozens of packages in a similar way. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants