sway: update to 1.9.

[AnInternetTroll]

• sway: update to 1.9.
• grimshot: update to 1.9+0

Testing the changes

• I tested the changes in this PR: YES

Local build testing

• I built this PR locally for my native architecture, (x86_64-glibc)

[caughtquick]

Sway uses wmenu as its default menu, and without it the default sway configuration is very hard to use (launch everything from terminal). Should wmenu be added as a dependency?

[AnInternetTroll]

Hi,

On Sun, Feb 25, 2024 at 04:10:20PM -0800, Abhijit Sipahimalani wrote: Sway uses `wmenu` as its default menu, and without it the default sway configuration is very hard to use (launch everything from terminal). Should `wmenu` be added as a dependency?

IMO no. Seems like the default config uses the following command:

`dmenu_path | wmenu | xargs swaymsg exec --`

This brings in dmenu as a dependency as well, which brings X11 as a dependency, which IMO is too far. Making wmenu as a dependency of sway will also make it harder for users to remove wmenu from their systems, as they'll have to add it as a ignorepkg option in their xbps config. I suppose an option would be to change this config line to something else that isn't as dependency heavy, but I am not very familiar with all options. Maybe wofi? It depends on gtk+3 so it might also be considered too much.

[rationalize-zz]

I am of the opinion that there should not be any additional dependencies added, for the following reasons:

• From a commit history perspective, the current merged version of Sway includes dmenu in the example config but does not count dmenu as a dependency. This is also true of the Foot terminal emulator.
• From a consistency perspective, the example sway config calls Foot as the terminal emulator. If dmenu/wmenu become dependencies by nature of being included the example config, consistency would also require including Foot as a dependency. My opinion is that it would be better to not include any of these as dependencies.
• From a design intention perspective, a WM is not a DE. WM should not become opinionated at a package level about which packages are "official" components of the WM. An alternative here would be to create some sort of "Sway-DE" meta-package if it is decided that a "works fresh out of the box" experience is wanted for this WM.

[caughtquick]

I definitely agree with the points made by @rationalize-zz, I use fuzzel and would have no use for the wmenu package, however it just doesn't sit right to me to have package ship in a "broken state", with errors in the config file by default just when run. Maybe just comment those parts of the config out?

[ahesford]

Suggested change

	version=1.9+0
	version=1.9+contrib.0

[ahesford]

Suggested change

	distfiles="https://github.com/OctopusET/sway-contrib/archive/refs/tags/${version%+*}-contrib.${version#*+}.tar.gz"
	distfiles="https://github.com/OctopusET/sway-contrib/archive/refs/tags/${version/+/-}.tar.gz"

[ahesford]

Do not add things like wmenu to depends. Users are expected to understand how to configure and use the packages they install. Sway will operate just fine without optional depenendencies like a menu or terminal emulator, whether or not the default (example) configuration specifies them. This might be a good application for optional dependencies in XBPS but, because XBPS does not support the concept, we don't hard-require optionals just so things work "out of the box".

[AnInternetTroll]

On Fri, Mar 01, 2024 at 07:49:16AM -0800, Andrew J. Hesford wrote: @ahesford requested changes on this pull request.

Done, thanks!

[zdykstra]

Is there anything left on this PR? Does it need more end-user testing?

[ahesford]

I think the consensus on IRC was to reject my suggest for 1.9+contrib.0 in favor of the original 1.9+0, which would require the distfiles substitution ${version/+/-contrib.}.

[AnInternetTroll]

I think the consensus on IRC was to reject my suggest for `1.9+contrib.0` in favor of the original `1.9+0`, which would require the distfiles substitution `${version/+/-contrib.}`.

@ahesford tbh I got also confused in that discussion. Anyway, implemented those changes.