Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-connections: update to 45.0 #49111

Closed
wants to merge 1 commit into from

Conversation

chrysos349
Copy link
Contributor

@chrysos349 chrysos349 commented Mar 5, 2024

split into a separate pr (#48762 (comment)).
a part of #48752

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl x
    • armv7l x
    • armv6l-musl x

@oreo639
Copy link
Member

oreo639 commented Mar 6, 2024

Hrm, I'm getting intermittent segfaults when trying to connect to localhost. I'll look in to it more later.

@chrysos349
Copy link
Contributor Author

chrysos349 commented Mar 6, 2024

I enabled remote desktop on localhost via gnome-remote-desktop (#49123), and successfully connected to localhost with gnome-connections. No segfaulting.

** UPD 1**
Actually, i reproduced the same intermittent segfaults when trying to connect to localhost. It happens when I copy an image to the clipboard.

../gdk/wayland/gdkselection-wayland.c:283: error reading selection buffer: Operation was cancelled
No data received from local clipboard for sending to remote side!

When I connect to the remote windows box, no segfaulting happens (even if I have an image in the clipboard).

Does it mean the bug is specific to localhost connections and has something to do with the clipboard contents? (Who needs connecting to the localhost anyway??)

UPD 2
here is what I found in release notes for gnome-connections-46.beta
see here - https://download.gnome.org/sources/gnome-connections/46/gnome-connections-46.beta.news

- Update gtk-frdp
     - Fix several crashes related to clipboard channel

that may be the reason fix for the crashes.

@chrysos349
Copy link
Contributor Author

chrysos349 commented Mar 6, 2024

The backported patch didn't fix crashes.

45.0 introduced clipboard channel support (via the update gtk-frdp widget), which causes crashes.
46.beta and 46.rc also crash.

44.0 doesn't exhibit this behavior, because it doesn't have clipboard channel.

AGAIN, the crash only happens with localhost connections. Remote connections don't crash, and I can successfully paste an image into the document on the windows box.

UPD 1
flatpak version of gnome-connections-45.0 crashes as well.

UPD 2
I filed a bug upstream (https://gitlab.gnome.org/GNOME/connections/-/issues/158)

@chrysos349
Copy link
Contributor Author

gnome-connections-45.0 on Ubuntu 23.10 also crashes when having something in the clipboard and connecting to localhost. So not a void-specific bug.

@fanyx
Copy link
Contributor

fanyx commented Apr 20, 2024

connections-46.0 has been released
any chance you want to look into building the newest version?
idk what your progress has been here

@chrysos349 chrysos349 closed this Apr 21, 2024
@chrysos349 chrysos349 deleted the gnome-connections branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants