Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpsm: remove package #49353

Merged
merged 1 commit into from
Jun 17, 2024
Merged

vpsm: remove package #49353

merged 1 commit into from
Jun 17, 2024

Conversation

meator
Copy link
Contributor

@meator meator commented Mar 18, 2024

I have created this PR because of https://www.reddit.com/r/voidlinux/comments/1bgdi51/recommend_way_to_update_xbpssrc_packages/

vpsm's latest commit has been made five years ago. I've reviewed the script, and it seems that everything is still functioning correctly. However, there's a possibility that any future changes to xbps-src could potentially break vpsm.

One might argue that this doesn't matter because it's not broken (yet). One could say that vpsm is feature complete and it doesn't need any updates. But it appears to me as though it has been abandoned.

vpsm isn't compiled, no packages require it and it doesn't need to be system installed. It therefore meets none of the quality requirements.

I personally hate these wrapper scripts because they do not provide any value of their own. vpsm doesn't really combine xtools, xbps-src and git to produce something, it just executes the appropriate commands 1:1. For example, vpsm update-sys = ./xbps-src update-sys, vpsm show-deps = ./xbps-src show-deps, vpsm push-commit
= git push -u etc.

This "hides the truth" from the user. Instead of using official, documented commands, vpsm users are encouraged to use vpsm (which uses those official commands) which adds an unnecessary layer of abstraction. Using official, documented commands should be preferred in my opinion.

But it isn't always 1:1. Users of vpsm might be surprised to find out1 that vpsm build-environment uses XBPS_CHROOT_CMD=uchroot, which is not the default way xbps-src is used. vpsm does special setup for this which requires superuser privileges, but it isn't properly documented. It also sets the set user ID bit on xbps-uchroot, which really should be documented. All of this shouldn't even happen in the first place, because xbps-uchroot has the right permissions set by default.

Testing the changes

  • I tested the changes in this PR: YES

Footnotes

  1. vpsm echos the commands used to set up the build environment, so the user will be made aware that XBPS_CHROOT_CMD=uchroot is used. However, I don't see it documented anywhere. Figuring this out as the commands are being run is too late.

@meator
Copy link
Contributor Author

meator commented Mar 18, 2024

Ping maintainer (and creator): @sinetoami, @sineto

@classabbyamp classabbyamp added the remove Package removal label Mar 18, 2024
Project appears to be dead, latest commit was made 5 years ago and vpsm
doesn't meet quality requirements.
@classabbyamp classabbyamp merged commit fb83167 into void-linux:master Jun 17, 2024
8 checks passed
@meator meator deleted the vpsm branch October 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remove Package removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants