Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igraph: update to 0.10.12. #50418

Merged
merged 1 commit into from
May 22, 2024
Merged

igraph: update to 0.10.12. #50418

merged 1 commit into from
May 22, 2024

Conversation

tornaria
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: briefly

@cinerea0 cinerea0 merged commit 6f95b4c into void-linux:master May 22, 2024
8 checks passed
@tornaria tornaria deleted the igraph branch May 22, 2024 20:06
@szhorvat
Copy link

@tornaria Have you considered adding the Python igraph package as well to Void Linux? It is an optional part of SageMath: https://doc.sagemath.org/html/en/reference/spkg/python_igraph.html

@tornaria
Copy link
Contributor Author

@tornaria Have you considered adding the Python igraph package as well to Void Linux? It is an optional part of SageMath: https://doc.sagemath.org/html/en/reference/spkg/python_igraph.html

I could do it if there is a direct use. Is sagemath (the library / the program) actually using igraph or python-graph?

@szhorvat
Copy link

I believe SageMath uses igraph as a dependency of rankwidth.

python-igraph is useful in Sage to gain access to igraph's algorithms, but not required. See https://doc.sagemath.org/html/en/reference/graphs/sage/graphs/generic_graph.html#sage.graphs.generic_graph.GenericGraph.igraph_graph

@tornaria
Copy link
Contributor Author

I believe SageMath uses igraph as a dependency of rankwidth.

It's a false dependency. Rankwidth uses igraph only for the binary rw. But sagemath only uses the shared library. We don't ship the rw binary on void linux, hence our rankwidth package does not depend on igraph.

python-igraph is useful in Sage to gain access to igraph's algorithms, but not required. See https://doc.sagemath.org/html/en/reference/graphs/sage/graphs/generic_graph.html#sage.graphs.generic_graph.GenericGraph.igraph_graph

I see, so if python-igraph is available, sagemath has a function to convert its own graphs to igraph and use them via python-igraph functions.

I don't do much graph theory myself, but if its useful (together with sage or on on its own), I could try to package it. I'm all in favor of packaging more math software for void linux.

@szhorvat
Copy link

It's a false dependency. Rankwidth uses igraph only for the binary rw. But sagemath only uses the shared library. We don't ship the rw binary on void linux, hence our rankwidth package does not depend on igraph.

In that case I actually don't know if there's anything else in SageMath that uses the igraph C library. There might not be.

The usage of igraph in rw is very sloppy and unmaintained (and would need patches for igraph 0.10), so if you can skip building the command line program, do so by all means.

I don't do much graph theory myself, but if its useful (together with sage or on on its own), I could try to package it. I'm all in favor of packaging more math software for void linux.

This would be nice. If you have questions while packaging, feel free to ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants