Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "accepted" options #9

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Adds "accepted" options #9

merged 4 commits into from
Oct 1, 2019

Conversation

yuric18
Copy link

@yuric18 yuric18 commented Jun 24, 2019

In some cases, for example, a 404 Not Found response, maybe another retry should not be the best thing to do, because probably the second request will give 404 again. With that, you can lose some performance.

So, I decided to add a new option called "accepted" that will reject immediately the request if the HTTP Status Code is included in the option.accepted (Array of Number), improving performance.

I also fixed some ESLINT errors on index.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 33

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.551%

Totals Coverage Status
Change from base Build 22: 0.2%
Covered Lines: 45
Relevant Lines: 45

💛 - Coveralls

Copy link
Owner

@void666 void666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Changes looks good to me! 👍

@void666 void666 merged commit 3086ee7 into void666:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants