Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

Pipeline #11

Merged
merged 11 commits into from
Apr 25, 2024
Merged

Pipeline #11

merged 11 commits into from
Apr 25, 2024

Conversation

JosLopes
Copy link
Collaborator

@JosLopes JosLopes commented Apr 21, 2024

An implementation of a pipeline so tasks with multiple programs can be executed!

Copy link
Owner

@voidbert voidbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a module called task_runner with a TODO comment telling to add pipelines there. Please move your code there and delete this module. Pipelines and single comments run in the same way

Copy link
Owner

@voidbert voidbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the first and last process separate conditions and integrate them all into the same for loop with the if statement inside. This way, you avoid a lot of bloat in the exec phase. See https://github.com/ruilopesm/System-Monitor-SO/blob/main/src/tracer.c#L244 as inspiration, if it helps you.

Copy link
Owner

@voidbert voidbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind with the changes. I found a very elegant solution online and fixed a file descriptor leak in it.

@JosLopes JosLopes merged commit 328c2a5 into main Apr 25, 2024
2 checks passed
@voidbert voidbert deleted the pipeline branch April 25, 2024 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants