-
Notifications
You must be signed in to change notification settings - Fork 1
Pipeline #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a module called task_runner
with a TODO
comment telling to add pipelines there. Please move your code there and delete this module. Pipelines and single comments run in the same way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the first and last process separate conditions and integrate them all into the same for loop with the if statement inside. This way, you avoid a lot of bloat in the exec phase. See https://github.com/ruilopesm/System-Monitor-SO/blob/main/src/tracer.c#L244 as inspiration, if it helps you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't mind with the changes. I found a very elegant solution online and fixed a file descriptor leak in it.
An implementation of a pipeline so tasks with multiple programs can be executed!