Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow moving folders to trash rather than completely deleting them #60

Open
haykam821 opened this issue Dec 11, 2019 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@haykam821
Copy link

Instead of rm-ing the folders when a delete is triggered, it would be helpful to have an option that trashes them instead such as --trash. This is much safer and reversible.

@zaldih zaldih added the enhancement New feature or request label Mar 29, 2020
@zaldih
Copy link
Member

zaldih commented Mar 31, 2020

Nice idea!

Maybe even a key combination with Del to send them there.
The only problem we see is that, as far as we know, the recycling bin is a graphic environment functionality. Therefore, does the recycling bin exist in servers? How would this be managed?

We raise these questions in case anyone reading this has a broader knowledge on the subject.

@haykam821
Copy link
Author

trash works already on servers.

@Fleker
Copy link

Fleker commented Oct 14, 2021

I'll take a look at integrating these two things together

@Fleker
Copy link

Fleker commented Oct 14, 2021

The Trash project is using some ESModule formatting which is making it infeasible to simply integrate this code. A lot of the library logic is relatively straightforward, but the dependencies themselves are ESModules so I got a bit stuck.

@Fleker
Copy link

Fleker commented Oct 16, 2021

Okay I think after reviewing a developer help guide and an open ts-node issue I'm on the right track. It does require some refactoring in this project, but I hope to have a PR ready soon.

Fleker added a commit to Fleker/npkill that referenced this issue Oct 16, 2021
The 'trash' NPM package is added
This dependency uses ESModule, requiring project refactoring
Fixes voidcosmos#60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants