Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from "custom" dependencies to public versions #3

Closed
bago opened this issue Sep 11, 2015 · 1 comment
Closed

Move from "custom" dependencies to public versions #3

bago opened this issue Sep 11, 2015 · 1 comment
Assignees
@bago
Labels
todo
Milestone
0.17

Comments

@bago
Copy link
Member

bago commented Sep 11, 2015

Currently mosaico depends on a few forked libraries:

"knockoutjs-reactor": "bago/knockoutjs-reactor#v1.3.6-mosaico",
"knockout-jqueryui": "bago/knockout-jqueryui#9452901885186c94f97b34535374cbe31405a882", 
"knockout.wrap": "bago/knockout.wrap#mosaico", 
"evol-colorpicker": "bago/colorpicker#mosaico",

I created PR for most of them, so as soon as they make releases we should update to official repositories.

  • knockoutjs-reactor has merged my PR, so we just need a new release
  • knockout-jqueryui just needs a small bower change and a new release
  • knockout.wrap asks for tests in order to merge support for the feature we need
  • evol-colorpicker already merged my PR, so we just need a release and an update in our code to deal with changes in "change" event.
@bago bago added the todo label Sep 11, 2015
@bago bago self-assigned this Dec 13, 2015
bago added a commit that referenced this issue Dec 13, 2015
@bago
Depdendencies update
6dc338b 
knockout-sortable updated to 0.11
knockout-reactor switched from private fork to master (part of #3)
knockout updated to 3.4.0 (fix #40)
@bago bago mentioned this issue Dec 21, 2015
Closed
@bago
Copy link
Member Author

bago commented Dec 21, 2015

Opened gvas/knockout-jqueryui#56

Knockout.wrap author first applied arj03/knockout.wrap#9 but then reverted it arj03/knockout.wrap#10

Evol-colorpicker should be ready to be switched to master.

bago added a commit that referenced this issue Oct 10, 2016
@bago
Switch to official knockout-jqueryui 2.2.3 release
338c4fc 
Part of #3
I got karma to knockout-jqueryui project and made a release, so we can
now depend on it.
bago added a commit that referenced this issue Feb 28, 2018
@bago
Move to official evol-colorpicker npm (new releases merged our PR, so…
80d8366 
… we don't need a fork anymore)

+ also fixed a comment in the colorpicker integration code.
Complete the fix for #3
@bago bago closed this as completed Feb 28, 2018
@bago bago added this to the 0.17 milestone Feb 28, 2018
mfrausto-mdw pushed a commit to mfrausto-mdw/mosaico that referenced this issue Mar 27, 2019
@deepak-srivastava
Merge pull request voidlabs#3 from progressivetech/issue288a
39494be 
avoid mixed content warnings when editing template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bago bago

Labels
todo
Projects
None yet
Milestone
0.17
Development

No branches or pull requests
1 participant
@bago