Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make preheader context aware and fix related tests #110

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Make preheader context aware and fix related tests #110

merged 1 commit into from
Oct 11, 2024

Conversation

codingjoe
Copy link
Member

@codingjoe codingjoe commented Oct 7, 2024 •
edited
Loading

@amureki you never tested the actual get_preheader method, since you accessed the preheader attribute, not the method 😉

@codingjoe codingjoe self-assigned this Oct 7, 2024
@codingjoe codingjoe requested a review from amureki October 7, 2024 08:42
amureki
amureki approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, right. Happens!

Thanks for the fix and a feature improvement!

@amureki amureki merged commit cb9ebc8 into main Oct 11, 2024
10 checks passed
@amureki amureki deleted the pre-header branch October 11, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amureki amureki amureki approved these changes

Assignees

@codingjoe codingjoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingjoe @amureki