Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add premailer instead of putting inline styles manually #18

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Conversation

amureki
Copy link
Member

@amureki amureki commented Mar 21, 2023

  • make use of https://github.com/peterbe/premailer instead of inlining styles manually into HTML
  • move styles to a separate file
  • remove voiio-branded colors and styles in favor of the original responsive template
  • added a few more blocks, preheader and footer

CleanShot 2023-03-21 at 16 05 36

@amureki amureki self-assigned this Mar 21, 2023
@amureki amureki changed the title Add premailer to instead of putting inline styles manually Add premailer instead of putting inline styles manually Mar 21, 2023
@amureki
Copy link
Member Author

amureki commented Mar 21, 2023

@codingjoe would love to hear your advice, should we keep premailer as an optional dependency?
If so, I'd need to keep an inlined version of base.html for people who would not want to install it.

@amureki amureki requested a review from codingjoe March 21, 2023 15:03
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, add the dependency. It seems like a solid choice, and I don't feel like maintaining both versions.

emark/templates/emark/styles.html Outdated Show resolved Hide resolved
@codingjoe
Copy link
Member

@amureki the powered by emark thing is funny. Maybe make that a DEBUG=true feature only ;)

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2f19b6b) 100.00% compared to head (0ed9eb4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          168       172    +4     
=========================================
+ Hits           168       172    +4     
Impacted Files Coverage Δ
emark/message.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amureki amureki marked this pull request as ready for review March 22, 2023 09:20
@amureki amureki requested a review from codingjoe March 22, 2023 09:20
emark/templates/emark/base.html Outdated Show resolved Hide resolved
emark/templates/emark/styles.css Show resolved Hide resolved
tests/test_message.py Outdated Show resolved Hide resolved
@amureki
Copy link
Member Author

amureki commented Mar 23, 2023

@codingjoe insightful as always! ✨

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Ferrell Reaction GIF

@amureki amureki merged commit 5254af8 into main Mar 23, 2023
@amureki amureki deleted the premailer branch March 23, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants