Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk insert tracking records #44

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Bulk insert tracking records #44

merged 1 commit into from
Jul 21, 2023

Conversation

codingjoe
Copy link
Member

@codingjoe codingjoe commented Jul 21, 2023

To reduce DB IO, we best insert all send records in bulk.

@codingjoe codingjoe self-assigned this Jul 21, 2023
@codingjoe codingjoe requested a review from amureki July 21, 2023 08:13
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a19ee41) 100.00% compared to head (98f504c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          322       327    +5     
=========================================
+ Hits           322       327    +5     
Impacted Files Coverage Δ
emark/backends.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe codingjoe enabled auto-merge (squash) July 21, 2023 08:16
Copy link
Member

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! 👍

@codingjoe codingjoe merged commit 861d8a7 into main Jul 21, 2023
15 checks passed
@codingjoe codingjoe deleted the bulk branch July 21, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants