Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for Django native email and add tracking console backend #45

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

codingjoe
Copy link
Member

@codingjoe codingjoe commented Jul 21, 2023

The new tracking backend didn't work for Django's native email messages but only the Emark once.

I also added a console backend that includes all tracking to have a consistent behavior in development and to be able to view HTML template rendering in a browser.

@codingjoe codingjoe self-assigned this Jul 21, 2023
@codingjoe codingjoe requested a review from amureki July 21, 2023 09:18
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (861d8a7) 100.00% compared to head (c4ebfa4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          327       346   +19     
=========================================
+ Hits           327       346   +19     
Impacted Files Coverage Δ
emark/migrations/0001_initial.py 100.00% <ø> (ø)
emark/backends.py 100.00% <100.00%> (ø)
emark/models.py 100.00% <100.00%> (ø)
emark/views.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amureki amureki merged commit d8989c0 into main Jul 21, 2023
15 checks passed
@amureki amureki deleted the native-bug branch July 21, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants