Add a dashboard with email previews #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amureki
force-pushed
the
preview-dashboard
branch
from
4132446
to
b9762ce
Compare
amureki
changed the title
codingjoe
reviewed
Aug 14, 2024
codingjoe
reviewed
Aug 23, 2024
codingjoe
approved these changes
Sep 25, 2024
herrbenesch
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Sweet! Really like the concept.
It's already a win to have a list of registered emails.
The rendered email itself does currently only provide a small improvement from just looking at the code. Especially given the following use cases:
- As a dev, I want a preview of email changes without the need to send one to myself
- As an email marketing person, I want to see the rendered emails as if they were sent to me directly.
IMHO This feature would be more useful if it rendered out the html. At least the include statements should be resolved.
Also we allow to mix html and markdown formatting which leads to broken looking email previews since only the markdown is rendered.
I'm ok with treating this as a preview feature. Rendered HTML would be actually useful though.
herrbenesch
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a way to access a dashboard with all available email classes used in the project.
/emark/dashboard/allows to see the list of emails/emark/dashboard/<str:email_class>/gets to the raw email preview without any values filledEMARK.DASHBOARD_HIDDEN_CLASSESallows to exclude certain classes (for example abstract base classes) from the dashboard