This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
Clarify file-heading comment note. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man, you beat me to the punch, I hadn't even filed the issue yet. LGTM once Travis confirms. |
designatednerd
added a commit
that referenced
this pull request
Aug 14, 2015
Clarify file-heading comment note.
|
Given what I've done (and am about to do) on DJWTHF, I'd like to come back and substantially clean up how templates are handled here, so that they aren't constant strings in the code... but I'm not sure if that'll make it no longer work as a standalone executable (without a template bundle folder on the side)—still thinking about that part. |
|
Yeah - I'd be more on the side of wanting to keep it a single executable file. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@designatednerd I just made the change, no version bump. What do you think?